Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support swaps with Ledger #4367

Closed
314159265359879 opened this issue Oct 17, 2023 · 2 comments · Fixed by #4548
Closed

Support swaps with Ledger #4367

314159265359879 opened this issue Oct 17, 2023 · 2 comments · Fixed by #4548
Assignees
@fbwoolf
Labels
area:swaps

Comments

@314159265359879
Copy link
Contributor

No description provided.

kyranjamie added a commit that referenced this issue Oct 27, 2023
@kyranjamie
chore: add ledger to swaps, closes #4367
056edd9
@fbwoolf fbwoolf mentioned this issue Oct 27, 2023
Merged
kyranjamie added a commit that referenced this issue Oct 30, 2023
@kyranjamie
chore: add ledger to swaps, closes #4367
e9a96e4
kyranjamie added a commit that referenced this issue Oct 30, 2023
@kyranjamie
chore: add ledger to swaps, closes #4367
43090e4
kyranjamie added a commit that referenced this issue Oct 30, 2023
@kyranjamie
chore: add ledger to swaps, closes #4367
122566f
kyranjamie added a commit that referenced this issue Oct 30, 2023
@kyranjamie
chore: add ledger to swaps, disabled, ref #4367
615ebb1
@markmhendrickson markmhendrickson linked a pull request Oct 30, 2023 that will close this issue
refactor(ledger): stacks signing #4425
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2023
@kyranjamie
chore: add ledger to swaps, disabled, ref #4367
5273dd4
kyranjamie pushed a commit that referenced this issue Nov 2, 2023
@semantic-release-bot
chore(release): 6.15.0
e813e55 
## [6.15.0](v6.14.0...v6.15.0) (2023-11-02)

### Features

* temporary fix for notification banners ([e349e0c](e349e0c))
* updated dlc-tools version, conditional bitcoin contracts entry point rendering ([194d102](194d102))

### Bug Fixes

* bug with go back action in send flow, [#4355](#4355) ([92aa04c](92aa04c))
* default icon stacks png ([eff18bf](eff18bf))
* fee calculation in for btc txs closes [#4455](#4455) ([cc5908b](cc5908b))
* fix typo in text, closes [#4461](#4461) ([6544d8e](6544d8e))
* improve styling of fund page in extension view ([ce31f2c](ce31f2c))
* removed attestor checking and argument from the bitcoin contract interface, better error handling ([7a0a2e8](7a0a2e8))

### Internal

* add ledger to swaps, disabled, ref [#4367](#4367) ([5273dd4](5273dd4))
* **ledger:** stacks signing, closes [#4420](#4420) ([6b8919b](6b8919b))
* post-release merge back ([24a124c](24a124c))
* swap asset list display name, closes [#4421](#4421) ([7c65fb3](7c65fb3))
@markmhendrickson markmhendrickson changed the title Support swaps on hardware/ledger enabled wallet Support swaps with Ledger Nov 20, 2023
@markmhendrickson
Copy link
Collaborator

We need to prepare a build with swaps enabled for ALEX team to investigate

@fbwoolf fbwoolf linked a pull request Nov 20, 2023 that will close this issue
chore: enable ledger swaps to test #4548
Merged
@fbwoolf fbwoolf removed a link to a pull request Nov 22, 2023
refactor(ledger): stacks signing #4425
Merged
@markmhendrickson
Copy link
Collaborator

@kyranjamie to help diagnose the underlying issue

pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@kyranjamie @pete-watters
chore: add ledger to swaps, disabled, ref leather-io#4367
0ad2499
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@semantic-release-bot @pete-watters
chore(release): 6.15.0
d5a328c 
## [6.15.0](leather-io/extension@v6.14.0...v6.15.0) (2023-11-02)

### Features

* temporary fix for notification banners ([e349e0c](leather-io@e349e0c))
* updated dlc-tools version, conditional bitcoin contracts entry point rendering ([194d102](leather-io@194d102))

### Bug Fixes

* bug with go back action in send flow, [leather-io#4355](leather-io#4355) ([92aa04c](leather-io@92aa04c))
* default icon stacks png ([eff18bf](leather-io@eff18bf))
* fee calculation in for btc txs closes [leather-io#4455](leather-io#4455) ([cc5908b](leather-io@cc5908b))
* fix typo in text, closes [leather-io#4461](leather-io#4461) ([6544d8e](leather-io@6544d8e))
* improve styling of fund page in extension view ([ce31f2c](leather-io@ce31f2c))
* removed attestor checking and argument from the bitcoin contract interface, better error handling ([7a0a2e8](leather-io@7a0a2e8))

### Internal

* add ledger to swaps, disabled, ref [leather-io#4367](leather-io#4367) ([5273dd4](leather-io@5273dd4))
* **ledger:** stacks signing, closes [leather-io#4420](leather-io#4420) ([6b8919b](leather-io@6b8919b))
* post-release merge back ([24a124c](leather-io@24a124c))
* swap asset list display name, closes [leather-io#4421](leather-io#4421) ([7c65fb3](leather-io@7c65fb3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbwoolf fbwoolf

Labels
area:swaps
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: enable ledger swaps to test leather-io/extension
4 participants
@markmhendrickson @kyranjamie @fbwoolf @314159265359879