Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BRC20 send flow broken: unexpected application error #4482

Closed
314159265359879 opened this issue Nov 4, 2023 · 2 comments · Fixed by #4484
Closed

BRC20 send flow broken: unexpected application error #4482

314159265359879 opened this issue Nov 4, 2023 · 2 comments · Fixed by #4484
Assignees
@alter-eggo
Labels
area:brc20 area:send bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds

Comments

@314159265359879
Copy link
Contributor

Steps to reproduce

  1. Clicking send in the wallet
  2. Picking any BRC-20 token
  3. Clicking continue

Unexpected Application Error!
[BigNumber Error] Argument not a primitive number:
Error: [BigNumber Error] Argument not a primitive number:
at intCheck (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/905.js:257254:11)
at P.shiftedBy (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/905.js:256769:5)
at chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:4522:26
at useBrc20SendForm (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:33998:113)
at Brc20SendForm (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:34042:7)
at Xh (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/905.js:188734:137)
at dj (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/905.js:188764:258)
at Wk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/905.js:188859:88)
at Vk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/905.js:188847:389)
at Uk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/905.js:188847:320)
at Jk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/905.js:188847:180)
at Ok (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/905.js:188838:88)
at Fk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/905.js:188840:300)
at jg (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/905.js:188694:105)
at chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/905.js:188834:273
@314159265359879 314159265359879 added bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds area:send area:brc20 labels Nov 4, 2023
@314159265359879
Copy link
Contributor Author

By the way, when I add an amount, I do not see this error pop up.

@fbwoolf
Copy link
Contributor

fbwoolf commented Nov 5, 2023

@alter-eggo, I've been working on this today and feel like I have a fix for this specific bug ...but then I run into quite few other things that are a bit strange with the routing. I think maybe you have more context on the implementation here? Reassign to me if you don't!

alter-eggo added a commit that referenced this issue Nov 6, 2023
@alter-eggo
fix: brc20 send form bug, closes #4482
3e667b5
@alter-eggo alter-eggo linked a pull request Nov 6, 2023 that will close this issue
fix: brc20 send form bug, closes #4482 #4484
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 6, 2023
@alter-eggo
fix: brc20 send form bug, closes #4482
a578e08
kyranjamie pushed a commit that referenced this issue Nov 7, 2023
@alter-eggo @kyranjamie
fix: brc20 send form bug, closes #4482
efba28d
kyranjamie pushed a commit that referenced this issue Nov 8, 2023
@semantic-release-bot
chore(release): 6.16.0
0db71d6 
## [6.16.0](v6.15.1...v6.16.0) (2023-11-08)

### Features

* change default test acc state ([9d00f06](9d00f06))
* process stacks ledger keys ([7e71b91](7e71b91))

### Bug Fixes

* brc20 send form bug, closes [#4482](#4482) ([a578e08](a578e08))
* **ledger:** stacks contract call signing, closes [#4478](#4478) ([6b81c01](6b81c01))
* map txid to txId to match new format of useExplorerLink, closes [#4446](#4446) ([cbf8814](cbf8814))
* migration redux persist ([bd77be5](bd77be5))
* refactor error label to align icon and make text consistent size, closes [#4166](#4166) ([eb69ae9](eb69ae9))
* sip10 tokens ledger send form, closes [#4491](#4491) ([1bd7837](1bd7837))
* themify yellow, red, green, blue ([642e08a](642e08a))

### Internal

* init ledger store refactor ([19eee1c](19eee1c))
* ledger store ([d3d86cc](d3d86cc))
* post-release merge back ([43750af](43750af))
* post-release merge back ([b9e726e](b9e726e))
* update icon, closes [#4166](#4166) ([b1e934e](b1e934e))
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@alter-eggo @pete-watters
fix: brc20 send form bug, closes leather-io#4482
f3378fb
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@semantic-release-bot @pete-watters
chore(release): 6.16.0
14fa21e 
## [6.16.0](leather-io/extension@v6.15.1...v6.16.0) (2023-11-08)

### Features

* change default test acc state ([9d00f06](leather-io@9d00f06))
* process stacks ledger keys ([7e71b91](leather-io@7e71b91))

### Bug Fixes

* brc20 send form bug, closes [leather-io#4482](leather-io#4482) ([a578e08](leather-io@a578e08))
* **ledger:** stacks contract call signing, closes [leather-io#4478](leather-io#4478) ([6b81c01](leather-io@6b81c01))
* map txid to txId to match new format of useExplorerLink, closes [leather-io#4446](leather-io#4446) ([cbf8814](leather-io@cbf8814))
* migration redux persist ([bd77be5](leather-io@bd77be5))
* refactor error label to align icon and make text consistent size, closes [leather-io#4166](leather-io#4166) ([eb69ae9](leather-io@eb69ae9))
* sip10 tokens ledger send form, closes [leather-io#4491](leather-io#4491) ([1bd7837](leather-io@1bd7837))
* themify yellow, red, green, blue ([642e08a](leather-io@642e08a))

### Internal

* init ledger store refactor ([19eee1c](leather-io@19eee1c))
* ledger store ([d3d86cc](leather-io@d3d86cc))
* post-release merge back ([43750af](leather-io@43750af))
* post-release merge back ([b9e726e](leather-io@b9e726e))
* update icon, closes [leather-io#4166](leather-io#4166) ([b1e934e](leather-io@b1e934e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alter-eggo alter-eggo

Labels
area:brc20 area:send bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: brc20 send form bug, closes #4482 leather-io/extension
3 participants
@fbwoolf @314159265359879 @alter-eggo