Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix styles in BRC-20 and Stacks contract execution areas #4587

Closed
markmhendrickson opened this issue Nov 28, 2023 · 3 comments · Fixed by #4711
Closed

Fix styles in BRC-20 and Stacks contract execution areas #4587

markmhendrickson opened this issue Nov 28, 2023 · 3 comments · Fixed by #4711
Assignees
@pete-watters
Labels
area:brc20 area:stacks-contract-execution

Comments

@markmhendrickson
Copy link
Collaborator

Especially the tiny "Learn more" link

Screenshot 2023-11-28 at 14 27 58
@markmhendrickson
Copy link
Collaborator Author

I presume the same issue is affecting the size of text here in the Stacks contract execution modal as well (e.g. factor attribute)

Screenshot 2023-11-29 at 12 11 23

@markmhendrickson markmhendrickson changed the title Fix styles in BRC-20 notice area Fix styles in BRC-20 and Stacks contract execution areas Nov 29, 2023
@markmhendrickson markmhendrickson mentioned this issue Dec 8, 2023
Closed
@pete-watters
Copy link
Contributor

@mica000 @fabric-8 do we have these designs in Figma anywhere?

If not can you let me know what font these should be? body.02 / caption.01 / label.01

Screenshot 2023-12-08 at 13 52 56
Screenshot 2023-12-08 at 13 46 37

I checked and there are a few places where we still specify the font using legacy methods so we probably have this bug in all those places.

Screenshot 2023-12-08 at 13 55 21

@pete-watters
Copy link
Contributor

We agreed to set these texts as body.02

pete-watters added a commit that referenced this issue Dec 18, 2023
@pete-watters
fix: deprecate legacy font sizes, closes #4587
e2384f8
pete-watters added a commit that referenced this issue Dec 18, 2023
@pete-watters
fix: deprecate legacy font sizes, closes #4587
81a5d5d
@pete-watters pete-watters linked a pull request Dec 18, 2023 that will close this issue
fix: deprecate legacy font sizes, closes #4587 #4711
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 18, 2023
@pete-watters
fix: deprecate legacy font sizes, closes #4587
5f539ca
@fbwoolf fbwoolf mentioned this issue Dec 18, 2023
Merged
kyranjamie pushed a commit that referenced this issue Dec 19, 2023
@semantic-release-bot
chore(release): 6.21.0
5390eed 
## [6.21.0](v6.20.0...v6.21.0) (2023-12-19)

### Features

* html video and audio inscription types, closes [#4077](#4077) and [#3556](#3556) ([e19eea4](e19eea4))
* modified contracts and balance fetching ([63d29ba](63d29ba))
* updated dlc tools version ([8dc1d22](8dc1d22))

### Bug Fixes

* collectibles refetch, closes [#4413](#4413) ([13aa68f](13aa68f))
* deprecate legacy font sizes, closes [#4587](#4587) ([5f539ca](5f539ca))
* handle inscription type svg, ref [#4727](#4727) ([b713c70](b713c70))
* only show swaps option on mainnet, closes [#4687](#4687) ([af6443c](af6443c))
* swaps test, ref [#4725](#4725) ([faae457](faae457))
* **wallet:** fees warning alignment fix ([d771bcc](d771bcc))

### Internal

* post-release merge back ([75f4998](75f4998))
pete-watters added a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@pete-watters
fix: deprecate legacy font sizes, closes leather-io#4587
d601588
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@semantic-release-bot @pete-watters
chore(release): 6.21.0
c336d43 
## [6.21.0](leather-io/extension@v6.20.0...v6.21.0) (2023-12-19)

### Features

* html video and audio inscription types, closes [leather-io#4077](leather-io#4077) and [leather-io#3556](leather-io#3556) ([e19eea4](leather-io@e19eea4))
* modified contracts and balance fetching ([63d29ba](leather-io@63d29ba))
* updated dlc tools version ([8dc1d22](leather-io@8dc1d22))

### Bug Fixes

* collectibles refetch, closes [leather-io#4413](leather-io#4413) ([13aa68f](leather-io@13aa68f))
* deprecate legacy font sizes, closes [leather-io#4587](leather-io#4587) ([5f539ca](leather-io@5f539ca))
* handle inscription type svg, ref [leather-io#4727](leather-io#4727) ([b713c70](leather-io@b713c70))
* only show swaps option on mainnet, closes [leather-io#4687](leather-io#4687) ([af6443c](leather-io@af6443c))
* swaps test, ref [leather-io#4725](leather-io#4725) ([faae457](leather-io@faae457))
* **wallet:** fees warning alignment fix ([d771bcc](leather-io@d771bcc))

### Internal

* post-release merge back ([75f4998](leather-io@75f4998))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
area:brc20 area:stacks-contract-execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: deprecate legacy font sizes, closes #4587 leather-io/extension
2 participants
@markmhendrickson @pete-watters