Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix password-related formatting issues #4606

Closed
markmhendrickson opened this issue Nov 30, 2023 · 4 comments · Fixed by #4716
Closed

Fix password-related formatting issues #4606

markmhendrickson opened this issue Nov 30, 2023 · 4 comments · Fixed by #4716

Comments

@markmhendrickson
Copy link
Collaborator

Related to fixes made with #4423

Across the unlock and set-password screens respectively.

Spacing issues

Screenshot 2023-11-30 at 12 44 55

Alignment issue

Screenshot 2023-11-30 at 12 44 32

Alignment issue

Screenshot 2023-11-30 at 12 44 28
@pete-watters
Copy link
Contributor

This seems similar to #4598 and we don't have a proper design for it

@pete-watters
Copy link
Contributor

Linking related issues:

pete-watters added a commit that referenced this issue Dec 18, 2023
@pete-watters
chore: improve display of lock screen, closes #4606
c634949
pete-watters added a commit that referenced this issue Dec 18, 2023
@pete-watters
chore: improve display of lock screen, closes #4606
237fa51
@pete-watters pete-watters linked a pull request Dec 18, 2023 that will close this issue
chore: improve display of lock screen, closes #4606 #4716
Merged
pete-watters added a commit that referenced this issue Dec 18, 2023
@pete-watters
chore: improve display of lock screen, closes #4606
c53f56c
@pete-watters
Copy link
Contributor

I made a few small changes here to make it look a bit better but we can revisit it once we have a design - #4598

Screenshot 2023-12-18 at 12 31 15

Kapture.2023-12-18.at.12.28.48.mp4

pete-watters added a commit that referenced this issue Dec 18, 2023
@pete-watters
chore: improve display of lock screen, closes #4606
e520cea
pete-watters added a commit that referenced this issue Dec 19, 2023
@pete-watters
chore: improve display of lock screen, closes #4606
ea7cdbe
github-merge-queue bot pushed a commit that referenced this issue Dec 19, 2023
@pete-watters
chore: improve display of lock screen, closes #4606
d0977cb
@pete-watters pete-watters mentioned this issue Dec 19, 2023
Merged
kyranjamie pushed a commit that referenced this issue Dec 19, 2023
@semantic-release-bot
chore(release): 6.21.1
89eeb89 
## [6.21.1](v6.21.0...v6.21.1) (2023-12-19)

### Bug Fixes

* remove stx deposit analytics ([0b123eb](0b123eb))

### Internal

* improve display of lock screen, closes [#4606](#4606) ([d0977cb](d0977cb))
* post-release merge back ([8639a2e](8639a2e))
@markmhendrickson
Copy link
Collaborator Author

Please move this issue to its updated board status 🙏

pete-watters added a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@pete-watters
chore: improve display of lock screen, closes leather-io#4606
a06cec0
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@semantic-release-bot @pete-watters
chore(release): 6.21.1
f28a445 
## [6.21.1](leather-io/extension@v6.21.0...v6.21.1) (2023-12-19)

### Bug Fixes

* remove stx deposit analytics ([0b123eb](leather-io@0b123eb))

### Internal

* improve display of lock screen, closes [leather-io#4606](leather-io#4606) ([d0977cb](leather-io@d0977cb))
* post-release merge back ([8639a2e](leather-io@8639a2e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: improve display of lock screen, closes #4606 leather-io/extension
2 participants
@markmhendrickson @pete-watters