Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending ordinals from regenerated addresses broke #4628

Closed
314159265359879 opened this issue Dec 3, 2023 · 2 comments · Fixed by #4646
Closed

Sending ordinals from regenerated addresses broke #4628

314159265359879 opened this issue Dec 3, 2023 · 2 comments · Fixed by #4646
Assignees
@kyranjamie
Labels
area:ordinals bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds

Comments

@314159265359879
Copy link
Contributor

Sending from the primary address to an other address is fine. I noticed an issue with Ledger and sending from regenerated addresses too (not sure if that is related: #4620)

Sending from a regenerated address to any other address is blocked at the point of selecting the fee... the wallet does not progress.

Video about that:

chrome-leather-bug.mp4
@314159265359879 314159265359879 added bug Functionality broken bug-p1 Critical functionality broken for many customers, with no clear workarounds area:ordinals labels Dec 3, 2023
@314159265359879
Copy link
Contributor Author

One of the users who encountered this tested the previous build (6.16.1) and then it works properly. Likely this was introduced with a change in 6.17.0.

@kyranjamie kyranjamie self-assigned this Dec 4, 2023
@kyranjamie
Copy link
Collaborator

Oversight on my part. This must've broken in creating a unified signing function.

@markmhendrickson markmhendrickson added bug-p2 Critical functionality broken for few users, with no clear workarounds and removed bug-p1 Critical functionality broken for many customers, with no clear workarounds labels Dec 4, 2023
kyranjamie added a commit that referenced this issue Dec 8, 2023
@kyranjamie
refactor(signing): support non-index zero input signing, closes #4620, …
420fb4f 
…#4628
@kyranjamie kyranjamie changed the title Sending ordinals from regenerated addresses broken Sending ordinals from regenerated addresses broke Dec 8, 2023
kyranjamie added a commit that referenced this issue Dec 8, 2023
@kyranjamie
refactor(signing): support non-index zero input signing, closes #4620, …
18c9dc0 
…#4628
github-merge-queue bot pushed a commit that referenced this issue Dec 8, 2023
@kyranjamie
refactor(signing): support non-index zero input signing, closes #4620, …
d2edb18 
…#4628
@markmhendrickson markmhendrickson linked a pull request Dec 11, 2023 that will close this issue
refactor(signing): support non-index zero input signing #4646
Merged
kyranjamie pushed a commit that referenced this issue Dec 12, 2023
@semantic-release-bot
chore(release): 6.19.0
d42aeea 
## [6.19.0](v6.18.0...v6.19.0) (2023-12-12)

### Features

* add rpc method for signing stacks messages ([e77a8d8](e77a8d8))

### Bug Fixes

* add background location to brc-20 modal and fix typo ([7483b9e](7483b9e))
* broadcast ledger swap ([886309b](886309b))
* fix brc-20 sendby signing transaction before finalising then broadcasting, closes [#4635](#4635) ([5aa7c3c](5aa7c3c))
* keep search params while doing background location redirect ([6b7ce6a](6b7ce6a))
* playwright error ([5bef424](5bef424))
* revert signing logic to try both keys, closes [#4645](#4645) ([8b1be50](8b1be50))
* selecting testnet in tests ([d275d8c](d275d8c))
* swap test route path ([24d3677](24d3677))

### Internal

* add ledger signing routes to BRC-20 send ([42ee981](42ee981))
* add swap tests ([bd6dc1a](bd6dc1a))
* enable ledger swaps to test ([6539075](6539075))
* post-release merge back ([9414a9b](9414a9b))
* **signing:** support non-index zero input signing, closes [#4620](#4620), [#4628](#4628) ([d2edb18](d2edb18))
Nithishvb pushed a commit to Nithishvb/extension that referenced this issue Dec 13, 2023
@kyranjamie @Nithishvb
refactor(signing): support non-index zero input signing, closes leath…
d134a7b 
…er-io#4620, leather-io#4628
Nithishvb pushed a commit to Nithishvb/extension that referenced this issue Dec 13, 2023
@semantic-release-bot @Nithishvb
chore(release): 6.19.0
3cfb001 
## [6.19.0](leather-io/extension@v6.18.0...v6.19.0) (2023-12-12)

### Features

* add rpc method for signing stacks messages ([e77a8d8](leather-io@e77a8d8))

### Bug Fixes

* add background location to brc-20 modal and fix typo ([7483b9e](leather-io@7483b9e))
* broadcast ledger swap ([886309b](leather-io@886309b))
* fix brc-20 sendby signing transaction before finalising then broadcasting, closes [leather-io#4635](leather-io#4635) ([5aa7c3c](leather-io@5aa7c3c))
* keep search params while doing background location redirect ([6b7ce6a](leather-io@6b7ce6a))
* playwright error ([5bef424](leather-io@5bef424))
* revert signing logic to try both keys, closes [leather-io#4645](leather-io#4645) ([8b1be50](leather-io@8b1be50))
* selecting testnet in tests ([d275d8c](leather-io@d275d8c))
* swap test route path ([24d3677](leather-io@24d3677))

### Internal

* add ledger signing routes to BRC-20 send ([42ee981](leather-io@42ee981))
* add swap tests ([bd6dc1a](leather-io@bd6dc1a))
* enable ledger swaps to test ([6539075](leather-io@6539075))
* post-release merge back ([9414a9b](leather-io@9414a9b))
* **signing:** support non-index zero input signing, closes [leather-io#4620](leather-io#4620), [leather-io#4628](leather-io#4628) ([d2edb18](leather-io@d2edb18))
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@kyranjamie @pete-watters
refactor(signing): support non-index zero input signing, closes leath…
8604633 
…er-io#4620, leather-io#4628
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@semantic-release-bot @pete-watters
chore(release): 6.19.0
95c9bcf 
## [6.19.0](leather-io/extension@v6.18.0...v6.19.0) (2023-12-12)

### Features

* add rpc method for signing stacks messages ([e77a8d8](leather-io@e77a8d8))

### Bug Fixes

* add background location to brc-20 modal and fix typo ([7483b9e](leather-io@7483b9e))
* broadcast ledger swap ([886309b](leather-io@886309b))
* fix brc-20 sendby signing transaction before finalising then broadcasting, closes [leather-io#4635](leather-io#4635) ([5aa7c3c](leather-io@5aa7c3c))
* keep search params while doing background location redirect ([6b7ce6a](leather-io@6b7ce6a))
* playwright error ([5bef424](leather-io@5bef424))
* revert signing logic to try both keys, closes [leather-io#4645](leather-io#4645) ([8b1be50](leather-io@8b1be50))
* selecting testnet in tests ([d275d8c](leather-io@d275d8c))
* swap test route path ([24d3677](leather-io@24d3677))

### Internal

* add ledger signing routes to BRC-20 send ([42ee981](leather-io@42ee981))
* add swap tests ([bd6dc1a](leather-io@bd6dc1a))
* enable ledger swaps to test ([6539075](leather-io@6539075))
* post-release merge back ([9414a9b](leather-io@9414a9b))
* **signing:** support non-index zero input signing, closes [leather-io#4620](leather-io#4620), [leather-io#4628](leather-io#4628) ([d2edb18](leather-io@d2edb18))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyranjamie kyranjamie

Labels
area:ordinals bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(signing): support non-index zero input signing leather-io/extension
4 participants
@markmhendrickson @kyranjamie @314159265359879 and others