Send SATS fails and lands on unknown route

[pete-watters]

I was testing this issue and encountered a bug when trying to send SATS.

I have SATS in one account and wanted to transfer them to another. I am not sure if this is supposed to work, any ideas @markmhendrickson ?

It seems weird as

• the route for send/brc20/sats/error page I land on isn't defined
• when I am doing a Send and choosing SATS it doesn't ask me where I want to send them

Kapture.2023-12-04.at.11.25.03.mp4

[markmhendrickson]

I'm getting the same but unsure the problem – will need checking the error logs, etc. to diagnose

The user should see a confirmation screen upon submission of the review screen

[markmhendrickson]

@pete-watters FYI I've moved this to the top of the backlog

[markmhendrickson]

I'm also seeing a related issue where my balance isn't recognized during sending. Prefer I file a separate issue or want to tackle jointly here?

[pete-watters]

I'm also seeing a related issue where my balance isn't recognized during sending. Prefer I file a separate issue or want to tackle jointly here?

It's OK to have them both fixed in this issue. Do you know if there was a design to go with this originally or else a ticket for how it's supposed to work?

I can try figure it out anyway. It seems it fails at creating the inscription which is the step before choosing a recipient?

[markmhendrickson]

@mica000 mind linking any of the BRC-20 materials we might have in Figma?

[markmhendrickson]

It seems it fails at creating the inscription which is the step before choosing a recipient?

Sending BRC-20 is unique in that it's a 2-step process, in which during the send flow, the only thing that really happens is the creation of an inscription via the OrdinalsBot API. No recipient is indicated within the send flow at this time.

Then later, the user comes back to the home screen and sends the inscription via the normal flow, indicating the recipient at that point.

[markmhendrickson]

It's also entirely possible there's an underlying Ordinalsbot API error thrown here and we aren't catching it, so it's worth checking. And we can contact their team as needed to help diagnose.

[pete-watters]

I checked this out and after clicking Create transfer inscription we get a 400 Bad Request error from https://blockstream.info/api/tx

It complains about:

sendrawtransaction RPC error: {"code":-26,"message":"non-mandatory-script-verify-flag (Witness program hash mismatch)"}

Then we crash unhandled.

This method fails in bitcoin-client.ts:

  async broadcastTransaction(tx: string) {
    // TODO: refactor to use `axios`
    // https://github.com/leather-wallet/extension/issues/4521
    // eslint-disable-next-line no-restricted-globals
    return fetch(`${this.configuration.baseUrl}/tx`, {
      method: 'POST',
      body: tx,
      headers: {
        'Content-Type': 'application/x-www-form-urlencoded',
      },
    });
  }

We added this functionality in this release

I think it may have been broken in #4316) by these refactors of useGenerateUnsignedNativeSegwitSingleRecipientTx :

• this commit
• this commit

Going back further to commit e9da65164273476ae4ba0c2de185dc07c7230d34 and it was working so it's something on our side. Any ideas here @kyranjamie ?

[kyranjamie]

Yep, looks like the refactor in the Ledger work broke this. We generate the tx, then try and broadcast it.

Previously this hook generated and signed the tx, which it no longer does. We need to sign the transaction with useSignBitcoinTx, finalise it, then broadcast it.

[pete-watters]

Thanks for the help here @kyranjamie . I think I have fixed it here as I submitted some things successfully.

@markmhendrickson in my fixing of this I had to spend ~ $70 on fees, sending a couple of transactions:

I saw what I think is another bug also where if I sign out of my wallet and then into our test wallet, my Pending BRC-20 transfers showed in the other wallet. This could be some weird caching issue.

Kapture.2023-12-08.at.16.16.42.mp4

This bug is fixed but I'm confused what the next step for moving these tokens is

1. I think we can have a better UX for where we show the Pending BTC-20 transfers - maybe it should be in Activity?
2. The Pending part is gone from my wallet now, as is the cost of the fees but I don't know what I'm supposed to do next. After some time should an Ordinal Inscription show up in my collectibles? If so, maybe we can add a placeholder entry there as a visual queue