Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Use ledger" button broken in modal, fine in full tab mode #4861

Closed
314159265359879 opened this issue Jan 25, 2024 · 1 comment
Closed

"Use ledger" button broken in modal, fine in full tab mode #4861

314159265359879 opened this issue Jan 25, 2024 · 1 comment
Assignees
@kyranjamie
Labels
area:ledger bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds

Comments

@314159265359879
Copy link
Contributor

Clicking here has no effect (chrome). Version 6.24.0 of the wallet.
image

Workaround, open the leather extension in a tab by right-clicking on the extension icon or in the extensions menu on the browser.
Then clicking "use Ledger" will get you to the next step.
@314159265359879 314159265359879 added bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds area:ledger labels Jan 25, 2024
@kyranjamie kyranjamie self-assigned this Jan 25, 2024
kyranjamie added a commit that referenced this issue Jan 25, 2024
@kyranjamie
chore: fix ledger, ref #4861
be371b5
github-merge-queue bot pushed a commit that referenced this issue Jan 25, 2024
@kyranjamie
chore: fix ledger, ref #4861
62bf0ec
@314159265359879
Copy link
Contributor Author

That was quick Kyran :-)

@fbwoolf fbwoolf mentioned this issue Jan 26, 2024
Merged
kyranjamie pushed a commit that referenced this issue Jan 26, 2024
@semantic-release-bot
chore(release): 6.26.0
d556f70 
## [6.26.0](v6.25.0...v6.26.0) (2024-01-26)

### Features

* **ui:** adds input element, ref [#4810](#4810) ([e223b0a](e223b0a))

### Bug Fixes

* filter out uneconomical utxos, closes [#4505](#4505) ([a6e116c](a6e116c))
* layout issue when stacking, ref [#4851](#4851) ([ce6c52a](ce6c52a))
* nested button tooltip error, closes [#4835](#4835) ([5b87e3d](5b87e3d))
* onboarding gate in ledger mode ([07729b5](07729b5))
* sign out of the wallet before proceeding with ledger sign in ([aa214c8](aa214c8))
* update psbt warning copy ([988e23f](988e23f))

### Internal

* add BulletSeparator story ([863a128](863a128))
* **deps:** bump vite from 5.0.11 to 5.0.12 ([4ec0cd9](4ec0cd9))
* fix ledger, ref [#4861](#4861) ([62bf0ec](62bf0ec))
* improve styles, try mnemonic ([f6bad6a](f6bad6a))
* post-release merge back ([be0d9a7](be0d9a7))
* remove dupe imports, lint ([b05f731](b05f731))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyranjamie kyranjamie

Labels
area:ledger bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyranjamie @314159265359879