Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fee estimation error #4832

Merged
merged 1 commit into from
Jan 21, 2024
Merged

fix: fee estimation error #4832

merged 1 commit into from
Jan 21, 2024

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Jan 20, 2024

Try out this version of Leather — Extension build, Test report

This PR should return the default min capped values for Stacks tx fee estimations if the query errors with a log message. I did not see that you can return the data in the onError function, so I created a new hook just to handle when the data is undefined ...that is what I was seeing when debugging this, but let me know if this is not what has been reported.

Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on Fara. I reckon it'd be better to change the fetcher to handle (rather than preventing access to query hook,like https://stackoverflow.com/a/73141514). What do you reckon?

But otherwise LGTM

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Jan 21, 2024

Thanks for taking on Fara. I reckon it'd be better to change the fetcher to handle (rather than preventing access to query hook,like https://stackoverflow.com/a/73141514). What do you reckon?

I can try to move it there today, np.

@fbwoolf fbwoolf added this pull request to the merge queue Jan 21, 2024
Merged via the queue into dev with commit 9b75521 Jan 21, 2024
28 checks passed
@fbwoolf fbwoolf deleted the fix/fee-estimation-error branch January 21, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to confirm transaction request on devnet
2 participants