Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AutoDupsort feature from kv_mdbx.go #10896

Closed
AskAlexSharov opened this issue Jun 25, 2024 · 0 comments · Fixed by #10940
Closed

Remove AutoDupsort feature from kv_mdbx.go #10896

AskAlexSharov opened this issue Jun 25, 2024 · 0 comments · Fixed by #10940
Assignees
@JkLondon
Labels
complexity:low Issue will take up to several days to fix erigon3 priority:medium
Milestone
3.0.0-alpha3

Comments

@AskAlexSharov
Copy link
Collaborator

AskAlexSharov commented Jun 25, 2024 •
edited
Loading

it's umbrella ticket for:
[] use less kv.PlainState and kv.HashedStorage in tests
[] move tx.del/put on native methods
[] then remove all if b.AutoDupSortKeysConversion from kv_mdbx.go (maybe it will unleash several new steps. better move by small steps).
[] try remove field MdbxCursor.bucketCfg
@AskAlexSharov AskAlexSharov added this to the 3.0.0-beta1 milestone Jun 25, 2024
@JkLondon JkLondon mentioned this issue Jul 1, 2024
Merged
@AskAlexSharov AskAlexSharov added the complexity:low Issue will take up to several days to fix label Jul 26, 2024
AskAlexSharov added a commit to stevemilk/erigon that referenced this issue Aug 23, 2024
@JkLondon @AskAlexSharov
[wip] removing autodupsort (erigontech#10940)
8ca1d16 
closes erigontech#10896

---------

Co-authored-by: JkLondon <ilya@mikheev.fun>
Co-authored-by: alex.sharov <AskAlexSharov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JkLondon JkLondon

Labels
complexity:low Issue will take up to several days to fix erigon3 priority:medium
Projects
None yet
Milestone
3.0.0-alpha3
Development

Successfully merging a pull request may close this issue.

removing autodupsort erigontech/erigon
3 participants
@yperbasis @AskAlexSharov @JkLondon