Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rasmusgo/parent hierarchy 2 #442

Merged
merged 3 commits into from
Aug 24, 2023
Merged

rasmusgo/parent hierarchy 2 #442

merged 3 commits into from
Aug 24, 2023

Conversation

rasmusgo
Copy link
Collaborator

Resolves #435 without removing the LocalTransform component. Supersedes #441.

kanerogers
kanerogers approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@kanerogers kanerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot better to me. Yeah, there's still a bit of annoying redundancy with the Local/Global transform split but I think we can live with that for now.

@rasmusgo rasmusgo merged commit c898dd8 into main Aug 24, 2023
3 checks passed
@rasmusgo rasmusgo deleted the rasmusgo/parent-hierarchy2 branch August 24, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanerogers kanerogers kanerogers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do parent hierarchy less dumb
2 participants
@rasmusgo @kanerogers