From 266669e3e4c52008621fcfd53777e6dfd6ce899b Mon Sep 17 00:00:00 2001 From: Louis Garman <75728+leg100@users.noreply.github.com> Date: Sat, 5 Aug 2023 08:56:15 +0100 Subject: [PATCH 1/3] chore: chromium bug fixed https://github.com/chromedp/chromedp/issues/1325#issuecomment-1666372303 --- .github/workflows/build.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 708c52926..591b2038c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,12 +27,6 @@ jobs: run: make vet - name: API tests run: make go-tfe-tests - # chromium breaks browser-based tests: - # https://github.com/chromedp/chromedp/issues/1325#issuecomment-1606114185 - - name: Remove chromium - run: | - sudo rm /usr/bin/chromium - sudo rm /usr/bin/chromium-browser - name: Tests env: GOOGLE_CREDENTIALS: ${{ secrets.GOOGLE_CREDENTIALS }} From e807163293dac2e20af26add9ef9a84a54e99f95 Mon Sep 17 00:00:00 2001 From: Louis Garman <75728+leg100@users.noreply.github.com> Date: Sat, 5 Aug 2023 09:22:02 +0100 Subject: [PATCH 2/3] Update main_test.go --- internal/integration/main_test.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/internal/integration/main_test.go b/internal/integration/main_test.go index 3b054c5a5..aca15b8d1 100644 --- a/internal/integration/main_test.go +++ b/internal/integration/main_test.go @@ -44,12 +44,6 @@ func TestMain(m *testing.M) { } func doMain(m *testing.M) (int, error) { - for _, chromium := range []string{"chromium", "chromium-browser"} { - if _, err := exec.LookPath(chromium); err == nil { - return 0, fmt.Errorf("found %s executable in path; chromium has a bug that breaks the browser-based tests; see https://github.com/chromedp/chromedp/issues/1325", chromium) - } - } - // Start external services if err := testcompose.Up(); err != nil { return 0, fmt.Errorf("starting external services: %w", err) From bf6fd5d28f41ffae44f7bee70ba8b3603fc743b1 Mon Sep 17 00:00:00 2001 From: Louis Garman Date: Sat, 5 Aug 2023 09:28:53 +0100 Subject: [PATCH 3/3] wip --- internal/integration/main_test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/integration/main_test.go b/internal/integration/main_test.go index aca15b8d1..a2adc6868 100644 --- a/internal/integration/main_test.go +++ b/internal/integration/main_test.go @@ -5,7 +5,6 @@ import ( "crypto/rand" "fmt" "os" - "os/exec" "path" "path/filepath" "testing"