Use new api for Artalk v2.5.0+ update #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qwqcode <qwqcode@gmail.com>
qwqcode
commented
Mar 16, 2023
| @@ -13,8 +13,8 @@ artalk: | |||
|
|
|||
| # Frontend resources CDN, you can set this to your preferred CDN | |||
| ## Reference: https://artalk.js.org/guide/frontend/install.html | |||
| jsUrl: https://unpkg.com/artalk@2/dist/Artalk.js | |||
| cssUrl: https://unpkg.com/artalk@2/dist/Artalk.css | |||
| jsUrl: https://artalk.example.com/dist/Artalk.js | |||
There was a problem hiding this comment.
后端程序中包含了对应版本的前端资源文件，可保证版本一致性，但同时也推荐使用 CDN 资源加快速度。
qwqcode
commented
Mar 16, 2023
| @@ -17,15 +16,15 @@ | |||
| condition: window.Artalk | |||
| })) | |||
| .then(() => { | |||
| new Artalk(CONFIG.artalk); | |||
| Artalk.init(CONFIG.artalk); | |||
There was a problem hiding this comment.
将 new Artalk 创建新实例对象替换为新版提供的函数，防止反复创建实例浪费资源
qwqcode
commented
Mar 16, 2023
| @@ -1,8 +1,7 @@ | |||
| {{ next_data('artalk', config.artalk, { | |||
| el: '#comments', | |||
| pageKey: url_for(page.path) | replace(r/index\.html$/, ''), | |||
| pageTitle: page.title, | |||
| locale: page.lang | default('zh-CN', true) | |||
qwqcode
commented
Mar 16, 2023
| useBackendConf: true |
There was a problem hiding this comment.
新版 useBackendConf 已修改为默认开启
|
@qwqcode 谢谢PR！ |
Closed
|
我又发现了点 BUG，将在下一个版本修复 😅 |
最新版 v2.5.2 应该修好了 |
|
@qwqcode 多谢多谢！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.5.0+ 新版更新了一些新的函数，有助于方便在 Pjax、SPA 的用例中快速集成 Artalk，对性能优化有助于解决内存泄露等问题。
https://artalk.js.org/develop/fe-api.html
但是还没在 hexo 中具体测试过，麻烦帮忙测一测 😁