-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow bulma-collapsible to work out of the box #81
base: main
Are you sure you want to change the base?
Conversation
I think it should definitely be doable to marry this script with the bulma-collapsible extension directly. I appreciate the pull request and will probably look at implementing a slightly modified version of this. Is the branch set to be editable by maintainers? |
The branch is set to be editable by maintainers |
I can't promise how soon I can look at this, but I will try to make time for it in the near future. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will rework this a bit to make the script come in automatically when this extension is selected.
This reverts commit d319f63.
Some mishaps made me force push and remove the commit, added it back
Hi @Ceres445, sorry this has taken forever, I've been a bit gone from the open source scene for an extended period. I've added a commit now that I think should make the user experience pretty smooth here. Can you test it for me, since I presume you have a project where this is applicable? The following statements should be true for this to be working as intended:
|
@lemonsaurus I tried to test this on my project, but for some reason my site crashes if i remove |
Added another script which makes the
bulma-collapsible
extension work, you need to use both the script and the extension for it to work. I think it would be easier to just use the extension and make it work, but I'm not sure if that would be possible to implement easily.