Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bulma-collapsible to work out of the box #81

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Ceres445
Copy link

Added another script which makes the bulma-collapsible extension work, you need to use both the script and the extension for it to work. I think it would be easier to just use the extension and make it work, but I'm not sure if that would be possible to implement easily.

@lemonsaurus
Copy link
Owner

I think it should definitely be doable to marry this script with the bulma-collapsible extension directly. I appreciate the pull request and will probably look at implementing a slightly modified version of this. Is the branch set to be editable by maintainers?

@Ceres445
Copy link
Author

The branch is set to be editable by maintainers

@lemonsaurus
Copy link
Owner

I can't promise how soon I can look at this, but I will try to make time for it in the near future. Thanks again!

Copy link
Owner

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will rework this a bit to make the script come in automatically when this extension is selected.

@lemonsaurus
Copy link
Owner

Hi @Ceres445, sorry this has taken forever, I've been a bit gone from the open source scene for an extended period.

I've added a commit now that I think should make the user experience pretty smooth here. Can you test it for me, since I presume you have a project where this is applicable?

The following statements should be true for this to be working as intended:

  • It should automatically add the runner you wrote if the collapsible is added without one.
  • If the runner has been added manually to the list of extensions, it should not add a duplicate runner.
  • If the collapsible extension is not used, it should not add the runner.
  • If "all" is specified in extensions, it should add both collapsible and the runner.

@lemonsaurus lemonsaurus dismissed their stale review August 7, 2023 09:17

stale, should be solved now.

@Ceres445
Copy link
Author

Ceres445 commented Oct 1, 2023

@lemonsaurus I tried to test this on my project, but for some reason my site crashes if i remove bulma-collapsible-runner from my config. Test Project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants