Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Hide to tray upon closing #93

Closed
AdamB2023 opened this issue Dec 27, 2022 · 17 comments
Closed

[Improvement] Hide to tray upon closing #93

AdamB2023 opened this issue Dec 27, 2022 · 17 comments

Comments

@AdamB2023
Copy link

ChatGPT isn't used constantly, but mostly when required, so having it in tray instead of taskbar would be the more comfortable option.

Could you add an option which makes hiding in tray when clicking close button, as an option?
There's a option now to hide, but it's in menu, means more user actions is needed.

@lencx
Copy link
Owner

lencx commented Dec 28, 2022

There is currently no API for hiding taskbar icons on platforms other than mac.

@AdamB2023
Copy link
Author

The app is moved to tray with hide option, and disappear from taskbar, so the API is available.
Just the behavior of using a close button could be different from now, so the user would make fewer clicks to achieve it.

@lencx
Copy link
Owner

lencx commented Dec 28, 2022

The hidden window is the main process of the chatgpt app, and if it exits, the app will exit.

@AdamB2023
Copy link
Author

It doesn't need to exit, it's a common standard for many Windows apps to stay only in tray (ex. Telegram, Caprine, Discord, Skype, Slack). They are handling the close button behavior differently than default app exit action.

@lencx
Copy link
Owner

lencx commented Dec 28, 2022

But none of them are based on tauri implementation. I am not currently able to solve the problem you describe, you can tell me by checking the tauri documentation, I would be happy to implement this feature.

@lencx lencx closed this as completed Dec 31, 2022
@AdamB2023
Copy link
Author

This may be helpful. It appears that you can attach hiding main window + tray on exit.
tauri-apps/tauri#2684

@lencx
Copy link
Owner

lencx commented Dec 31, 2022

That's how it's handled now, and it's not the problem you want to solve. https://github.com/lencx/ChatGPT/blob/main/src-tauri/src/main.rs#L77-L91

@AdamB2023
Copy link
Author

Also https://tauri.app/v1/guides/features/system-tray/

We have both:

  1. Closing with [x] - it hides main window, but keep on taskbar
  2. ChatpGPT -> Hide (ctrl+H) - it hides main window, and remove from taskbar

What was requested is handling [x] like in 2.

@lencx
Copy link
Owner

lencx commented Dec 31, 2022

You can hide the window in 2, but you cannot remove it from the taskbar.

@AdamB2023
Copy link
Author

AdamB2023 commented Dec 31, 2022

The (2) option is removing from taskbar.
Video: https://dl.dropboxusercontent.com/s/5w4avalm5ehzzck/20221231_1672495193.mp4

@lencx
Copy link
Owner

lencx commented Dec 31, 2022

Removing it from the taskbar will kill the program.

@AdamB2023
Copy link
Author

AdamB2023 commented Dec 31, 2022

No, the program is still running, and can be opened from tray.
Vide: https://dl.dropboxusercontent.com/s/b9rvrpzkya1vewb/20221231_1672495290.mp4

@lencx
Copy link
Owner

lencx commented Dec 31, 2022

I see what you're saying, it's hidden on windows, but it won't work on mac.

The tray opens the tray window, which is two different windows from the main window. And how do I redisplay the main window?

@bokkoman
Copy link

bokkoman commented Mar 1, 2023

Can't the Hide (ctrl+h) not be the X for closing? Cause this is quite annoying as it is now.
The shortcut doesn't work for me, no idea why. But when I hide it, and then click the tray icon, it opens the window again together with the smaller tray window.

@lencx
Copy link
Owner

lencx commented Mar 1, 2023

Can't the Hide (ctrl+h) not be the X for closing? Cause this is quite annoying as it is now. The shortcut doesn't work for me, no idea why. But when I hide it, and then click the tray icon, it opens the window again together with the smaller tray window.

You can now tap [x] to exit the application (Control Center -> Settings -> Main Window -> Close Exit).

@bokkoman
Copy link

bokkoman commented Mar 2, 2023

This doesn't work. Well it does, but it closes the whole process, so even the tray icon is closed.

@SnowPowerCore
Copy link

+1, close button only hides the main window, but on Windows most of the times expected behavior is to close GUI window, but keep the tray process. Would be really amazing to have a behavior like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants