From b646cf6365cdac852585083a51cfa44462bca51a Mon Sep 17 00:00:00 2001 From: Leo Balter Date: Wed, 17 Apr 2019 16:13:17 -0400 Subject: [PATCH] Add tests for Promise.all|race resolve lookup Ref tc39/ecma262#1506 --- .../invoke-resolve-get-once-multiple-calls.js | 45 +++++++++++++++++++ .../all/invoke-resolve-get-once-no-calls.js | 42 +++++++++++++++++ .../invoke-resolve-get-once-multiple-calls.js | 45 +++++++++++++++++++ .../race/invoke-resolve-get-once-no-calls.js | 41 +++++++++++++++++ 4 files changed, 173 insertions(+) create mode 100644 test/built-ins/Promise/all/invoke-resolve-get-once-multiple-calls.js create mode 100644 test/built-ins/Promise/all/invoke-resolve-get-once-no-calls.js create mode 100644 test/built-ins/Promise/race/invoke-resolve-get-once-multiple-calls.js create mode 100644 test/built-ins/Promise/race/invoke-resolve-get-once-no-calls.js diff --git a/test/built-ins/Promise/all/invoke-resolve-get-once-multiple-calls.js b/test/built-ins/Promise/all/invoke-resolve-get-once-multiple-calls.js new file mode 100644 index 00000000000..4358ff5296a --- /dev/null +++ b/test/built-ins/Promise/all/invoke-resolve-get-once-multiple-calls.js @@ -0,0 +1,45 @@ +// Copyright (C) 2019 Leo Balter. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +description: > + Gets constructor's `resolve` method once from zero to many invocations. +esid: sec-promise.all +info: | + Runtime Semantics: PerformPromiseAll + + 1. Let promiseResolve be ? Get(constructor, `"resolve"`). + 1. If IsCallable(promiseResolve) is false, throw a TypeError exception. + ... + 1. Repeat, + ... + 1. Let nextPromise be ? Call(promiseResolve, constructor, « nextValue »). +---*/ + +var p1 = Promise.resolve(1); +var p2 = Promise.resolve(1); +var p3 = Promise.reject(1); +var p4 = Promise.resolve(1); +var resolve = Promise.resolve; +var getCount = 0; +var callCount = 0; + +Object.defineProperty(Promise, 'resolve', { + configurable: true, + get() { + getCount += 1; + return function() { + callCount += 1; + return resolve.apply(Promise, arguments); + }; + } +}); + +Promise.all([p1, p2, p3, p4]); + +assert.sameValue( + getCount, 1, 'Got `resolve` only once for each iterated value' +); +assert.sameValue( + callCount, 4, '`resolve` invoked once for each iterated value' +); diff --git a/test/built-ins/Promise/all/invoke-resolve-get-once-no-calls.js b/test/built-ins/Promise/all/invoke-resolve-get-once-no-calls.js new file mode 100644 index 00000000000..36f7fc7c214 --- /dev/null +++ b/test/built-ins/Promise/all/invoke-resolve-get-once-no-calls.js @@ -0,0 +1,42 @@ +// Copyright (C) 2019 Leo Balter. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +description: > + Gets constructor's `resolve` method once from zero to many invocations. +esid: sec-promise.allsettled +info: | + Runtime Semantics: PerformPromiseAll + + 1. Let promiseResolve be ? Get(constructor, `"resolve"`). + 1. If IsCallable(promiseResolve) is false, throw a TypeError exception. + ... + 1. Repeat, + ... + 1. Let nextPromise be ? Call(promiseResolve, constructor, « nextValue »). +features: [Promise.allSettled] +---*/ + +var resolve = Promise.resolve; +var getCount = 0; +var callCount = 0; + +Object.defineProperty(Promise, 'resolve', { + configurable: true, + get() { + getCount += 1; + return function() { + callCount += 1; + return resolve.apply(Promise, arguments); + }; + } +}); + +Promise.all([]); + +assert.sameValue( + getCount, 1, 'Got `resolve` only once for each iterated value' +); +assert.sameValue( + callCount, 0, '`resolve` not called for empty iterator' +); diff --git a/test/built-ins/Promise/race/invoke-resolve-get-once-multiple-calls.js b/test/built-ins/Promise/race/invoke-resolve-get-once-multiple-calls.js new file mode 100644 index 00000000000..bddd0ade611 --- /dev/null +++ b/test/built-ins/Promise/race/invoke-resolve-get-once-multiple-calls.js @@ -0,0 +1,45 @@ +// Copyright (C) 2019 Leo Balter. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +description: > + Gets constructor's `resolve` method once from zero to many invocations. +esid: sec-promise.race +info: | + Runtime Semantics: PerformPromiseRace + + 1. Let promiseResolve be ? Get(constructor, `"resolve"`). + 1. If IsCallable(promiseResolve) is false, throw a TypeError exception. + ... + 1. Repeat, + ... + 1. Let nextPromise be ? Call(promiseResolve, constructor, « nextValue »). +---*/ + +var p1 = Promise.resolve(1); +var p2 = Promise.resolve(1); +var p3 = Promise.reject(1); +var p4 = Promise.resolve(1); +var resolve = Promise.resolve; +var getCount = 0; +var callCount = 0; + +Object.defineProperty(Promise, 'resolve', { + configurable: true, + get() { + getCount += 1; + return function() { + callCount += 1; + return resolve.apply(Promise, arguments); + }; + } +}); + +Promise.race([p1, p2, p3, p4]); + +assert.sameValue( + getCount, 1, 'Got `resolve` only once for each iterated value' +); +assert.sameValue( + callCount, 4, '`resolve` invoked once for each iterated value' +); diff --git a/test/built-ins/Promise/race/invoke-resolve-get-once-no-calls.js b/test/built-ins/Promise/race/invoke-resolve-get-once-no-calls.js new file mode 100644 index 00000000000..3c3c27dd7e0 --- /dev/null +++ b/test/built-ins/Promise/race/invoke-resolve-get-once-no-calls.js @@ -0,0 +1,41 @@ +// Copyright (C) 2019 Leo Balter. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +description: > + Gets constructor's `resolve` method once from zero to many invocations. +esid: sec-promise.race +info: | + Runtime Semantics: PerformPromiseRace + + 1. Let promiseResolve be ? Get(constructor, `"resolve"`). + 1. If IsCallable(promiseResolve) is false, throw a TypeError exception. + ... + 1. Repeat, + ... + 1. Let nextPromise be ? Call(promiseResolve, constructor, « nextValue »). +---*/ + +var resolve = Promise.resolve; +var getCount = 0; +var callCount = 0; + +Object.defineProperty(Promise, 'resolve', { + configurable: true, + get() { + getCount += 1; + return function() { + callCount += 1; + return resolve.apply(Promise, arguments); + }; + } +}); + +Promise.race([]); + +assert.sameValue( + getCount, 1, 'Got `resolve` only once for each iterated value' +); +assert.sameValue( + callCount, 0, '`resolve` not called for empty iterator' +);