Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindGust is missing for PWSWeather #4

Closed
judgetom opened this issue Apr 23, 2021 · 4 comments
Closed

WindGust is missing for PWSWeather #4

judgetom opened this issue Apr 23, 2021 · 4 comments

Comments

@judgetom
Copy link

Hello,

in the function updatePWSWeather_() the following line is missing:
if (station.imperial.windGust != null) request += '&windgustmph=' + station.imperial.windGust;

By adding this line the windGust will also be provided.

Best regards, and thanks for the script,
judgetom

@leoherzog
Copy link
Owner

Thanks! I was basing this built URL off of the PWSWeather uploader in acuparse.

https://gitlab.com/acuparse/acuparse/-/blob/dev/src/fcn/cron/uploaders/pwsweather.php

Is this parameter actually supported by PWSWeather? They don't have any API docs :(

@leoherzog
Copy link
Owner

@judgetom
Copy link
Author

Yes, it works well since I added it.

@leoherzog
Copy link
Owner

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants