Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual trigger support #40

Open
cd-a opened this issue Feb 27, 2024 · 4 comments
Open

Manual trigger support #40

cd-a opened this issue Feb 27, 2024 · 4 comments

Comments

@cd-a
Copy link

cd-a commented Feb 27, 2024

Following up on your comment on #21 (comment)

Isn't that now implemented in helix via helix-editor/helix#9660?

@sigmaSd
Copy link
Contributor

sigmaSd commented Feb 27, 2024

Unfortunately that doesn't help a lot, the spec says that CompltionKind::Invoked is triggered even when typing an identifier, so in practice helix will always request completions, that pr just fixed the metadata sent back to the sever https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionTriggerKind

@sigmaSd
Copy link
Contributor

sigmaSd commented Mar 13, 2024

What if there is was an option to disable completion completely, and add completion as a code action, I think that would solve this problem , now the user can decide when to ask for the completion

I think its a good idea what do you think @leona ?

@sigmaSd
Copy link
Contributor

sigmaSd commented Mar 13, 2024

It works but its rough on the edges, too bad thought I found a solution for this problem
Screencast from 2024-03-13 17-41-25.webm

@jkaye2012
Copy link

Hey there, any movement or ideas around this?

I find that completion with ctrl-x works quite well, but it's pretty annoying to have the automatic suggestions popping up all over the place, even with --triggerCharacters "". The inability to disable automatic completion is the only thing holding me back from being able to use this great tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants