Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubles creating "View Repository" button #165

Closed
hyperupcall opened this issue Dec 19, 2022 · 4 comments
Closed

Troubles creating "View Repository" button #165

hyperupcall opened this issue Dec 19, 2022 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@hyperupcall
Copy link

hyperupcall commented Dec 19, 2022

Hi,

Coming from Crawl's extension because this one starts up in half the time (thanks!), and I'm having trouble enabling the "view repository" button.

I looked at the Feature Contributions, and I tried to set vscord.status.buttons.button1.git.active.enabled to true, since it seemed that it would do what I want, but that didn't do anything.

I also tried to add this config, to no avail:

{
   "vscord.status.buttons.button1.active.enabled": true,
   "vscord.status.buttons.button1.active.label": "View Repository",
   "vscord.status.buttons.button1.active.url": "{git_url}",
}

So I'm asking, how would I go about doing this, since it seems this feature is suported?

Maybe this issue is related to #151. For me, a more intuitive system would have a configuration like so:

"vscode.status.buttonActive": "myButtonA", 
"vscode.status.buttons": {
  "myButtonA": { ... },
  "myButtonB": { ... },
}

That way, an arbitrary amount of buttons can be added without cluttering the "Feature Contributions" extension tab. It would also be really simple to have have multiple builtin buttons and then be able to specify through buttonActive. Maybe you can make the image parts of the config object-based too Of course this would have to be documented somewhere...

@xhayper
Copy link
Collaborator

xhayper commented Dec 19, 2022

why did we never think of that @leonardssh @nick22985 XD

it might also be a bug too, i will have to talk with two contributors I mentioned first.

@nick22985
Copy link
Collaborator

nick22985 commented Dec 19, 2022

That is a better way of formatting it xD and hanling lol

Also weird how view repo isn't working. Will have 2 look it works fine for me

@xhayper
Copy link
Collaborator

xhayper commented Dec 19, 2022

nick, can try it and see if the settings menu show "Edit in settings.json" or easy to edit gui

@xhayper xhayper added bug Something isn't working enhancement New feature or request labels Dec 20, 2022
@nick22985
Copy link
Collaborator

Dont have much time atm will get to this when I can unless someone else wants to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants