-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add Playwright or wasm-bindgen-test
testing for examples and run them using cargo-make
#210
Comments
Progress ReportGitHub WorkflowsExample workflows only run when needed.
Cargo MakeCustom
CI TestingCI test runners by example...
counter -C-W
counters -W
counters_stable -W-P
counter_without_macros -R-W
js-framework-benchmark -W
router -P
tailwind -L
Test Runners: C = Cargo Test, L = Cargo Leptos Test, P = Playwright Test, R = RS Test, W = WASM Test
What's Left?We have a stable example testing platform with a nice DX. Apart from adding more tests, one potential improvements come to mind.
@gbj Is there anything else that should be considered? |
No, I think this is really comprehensive. Your work here has been really astounding, and it's completely outside my area of knowledge so I appreciate it very much. CI process-wise, your pending "Only run Test-wise, I think the most useful remaining tests to add are
I don't think we need 100% example test coverage. What's already tested + the above sufficiently tests the features of the framework, in my opinion, as well as providing examples of how to test effectively, which are the two goals. |
I'm going to close this as completed. Thank you @agilarity for a huge amount of work on this. We're now testing a wide range of features of the framework pretty thoroughly via the examples, and these provide a really strong reference for how users can implement testing in their own apps. Feel free to open separate issues in the future for additional testing needs, but this one has been well done. |
No description provided.
The text was updated successfully, but these errors were encountered: