Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: explore adding cargo-semver-checks #2229

Closed
gbj opened this issue Jan 26, 2024 · 1 comment · Fixed by #2450
Closed

CI: explore adding cargo-semver-checks #2229

gbj opened this issue Jan 26, 2024 · 1 comment · Fixed by #2450
Labels
help wanted Extra attention is needed

Comments

@gbj
Copy link
Collaborator

gbj commented Jan 26, 2024

Is your feature request related to a problem? Please describe.
I'd like additional help from CI in identifying possible breaking API changes in PRs.

Describe the solution you'd like
Adding cargo-semver-checks as part of CI won't catch every possible breaking change, but could be an extra layer of protection.

Open to other thoughts!
@gbj gbj added the help wanted Extra attention is needed label Jan 26, 2024
@agilarity
Copy link
Contributor

They recommend pinning the nightly version.

I can add a workflow to run this after #2272 is merged. It pins the nightly version.

You may also want to run the cargo-semver-checks when a version tag is added.

@agilarity agilarity mentioned this issue Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(ci): check semver agilarity/leptos
2 participants
@gbj @agilarity