-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use symlinks with relative paths instead of absolute on non-windows environments #423
Comments
Hmm... thanks for reporting this @JaapRood. So, it sounds like:
Is that right? Would a solution here be to only convert to absolute destinations on windows? That would leave build/move broken on Windows, but it would at least allow build to work on windows and also allow build/move to work in other environments. |
Oh, I see that's exactly what you've suggested in the issue title. 😆 That sounds great. @JaapRood Are you interested in taking this on? |
@gigabo that's exactly right. I don't have access to a windows machine with development environment, so I'll need help on that front, but I'll give it a go and see how far I get. |
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
It seems that with the great effort to make symlinks work on win32 portability of a lerna repo has been reduced, as the use of "junction" to create a symlink requires the use an absolute destination path. What this means is that after running
lerna bootstrap
and then moving the project folder, all symlinks are invalid and no longer point to an existing directory.Why care? When deploying a repo that uses Lerna to Heroku the app gets built in a temporary folder, to then be copied over to it's runtime destination. You can run
lerna bootstrap
before booting your server, however, this also means any otherprepublish
hooks will be triggered, causing much of the app to build again (as that's the main means of building node apps before they are deployed on Heroku).The text was updated successfully, but these errors were encountered: