-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lerna assumes it manages git root #555
Comments
You can use the |
Thanks for the answer @doug-wade, the packages location is actually not the problem, adapting that path works fine. The problem lies in lerna thinking its not been |
@joscha I think in this case a repro repository would be best, since then I can clone it and use it locally -- unless there's some cool gist feature I don't know about, to use it locally would take a lot of copy-paste. |
sure, @doug-wade, repo is here: https://github.com/joscha/lerna-broken-nesting-example |
@doug-wade were you able to verify the problem or is there anything else I can provide? |
@joscha I understand this problem, and I could've sworn there were a couple other issues recently with basically the same problem. In any case... Right now, we are indeed making the assumption that Alternatively, we could use a package like find-up to locate TODOs, as I see them:
PRs welcome. :) |
Thanks for the answer @evocateur - we had to abandon our plans to use lerna in the meantime, due to #377 and also a few comments here and there that suggested that lerna functionality might be picked up by yarn, so I won't be investing time in this issue for now. We can close the issue or leave it open (as I think other people might have similar issues and might be interested in following through the TODOs). |
I understand completely, @joscha. We'll leave this open so it's easier for others with the same issue to find. |
🎉 thanks @evocateur |
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
When using lerna within a folder of a repository, e.g.
it assumes that the
lerna.json
andpackage.json
file will live in the root folder, e.g. creating a structure like this:if I move
lerna.json
into theproject-a
folder and add lerna to the dependencies of thatpackage.json
I getwhen running
lerna bootstrap
from withinproject-a
.Would you accept a PR that teaches lerna to stop searching for a lerna config in the git root if it is invoked from a subdirectory which has a valid
package.json
(e.g."dependencies": { "lerna": "2.0.0-beta.34" }
) and a validlerna.json
?The text was updated successfully, but these errors were encountered: