Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight.js preprocessing no longer generating correctly #104

Closed
lukeapage opened this issue Feb 5, 2014 · 9 comments
Closed

highlight.js preprocessing no longer generating correctly #104

lukeapage opened this issue Feb 5, 2014 · 9 comments

Comments

@lukeapage
Copy link
Member

@jonschlinkert looking into setting marked to use 3.0.0 to fix this issue.

@jonschlinkert
Copy link
Contributor

@lukeapage did you find specific places where it isn't generating correctly? I haven't even had time to debug the marked stuff, since I was trying to get all the other packages updated.

@lukeapage
Copy link
Member Author

sorry I created this in a rush. I meant highlight.js pre-processing

@jonschlinkert
Copy link
Contributor

I'm thinking it still might have something to do with the changes in marked... I've had issue on several projects now. let me know if you figure anything out. I'l do the same

@lukeapage lukeapage reopened this Feb 16, 2014
@lukeapage
Copy link
Member Author

see markedjs/marked#350

if you want it to work, find marked in node_modules under marked-extras (for me it was under handlebars-helper-compose and copy and paste the 3.0.0 version in there

@lukeapage
Copy link
Member Author

@jonschlinkert when you updated less.github.io you didn't apply the above hack, so syntax highlighting was lost.. I'm going to update it now with my hacked version.
I'll hack a look now to see if upgrading dependencies removes the need for this hack

@lukeapage
Copy link
Member Author

@jonschlinkert upgrading dependencies works but breaks the site "improve this section" links :(

I'll try upgrading parts to get a working configuration.

@lukeapage
Copy link
Member Author

@jonschlinkert I think just deleting node_modules and re-installing will fix it, but I also upgraded some depencies

@jonschlinkert
Copy link
Contributor

k, I'll give it a go thx

@jonschlinkert
Copy link
Contributor

yeah reinstalling node_modules seems to do the trick. also it looks like the syntax highlighting is improved now. so that's a plus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants