Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we update to 4.1.2? #3653

Closed
nring opened this issue Oct 6, 2021 · 5 comments
Closed

Should we update to 4.1.2? #3653

nring opened this issue Oct 6, 2021 · 5 comments

Comments

@nring
Copy link

nring commented Oct 6, 2021

@matthew-dean I noticed that Less 4.1.2 is up on NPM, but the GitHub releases page still only lists 4.1.1. Furthermore, not all of the CI tests for 4.1.2 completed successfully.

@matthew-dean
Copy link
Member

@nring the failing test, to my knowledge, is because Node changed its error format in the latest Node, so there's a string compare failing, but there's nothing wrong in terms of functionality.

@iChenLei correct?

@iChenLei
Copy link
Member

iChenLei commented Oct 6, 2021

@matthew-dean yes. PR #3652 to fix it

@iChenLei
Copy link
Member

iChenLei commented Oct 7, 2021

@matthew-dean So update the github releases ?

@nring
Copy link
Author

nring commented Oct 9, 2021

Thanks for the background on the issue. Is there a plan to release 4.1.3 with the CI fix or will this be the final release for a while.

@iChenLei
Copy link
Member

@nring Thanks for your advices, I will create a pr for it, need review from matthew-dean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants