Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context window from configure not being used in agent config.json #434

Closed
cpacker opened this issue Nov 12, 2023 · 1 comment · Fixed by #435
Closed

Context window from configure not being used in agent config.json #434

cpacker opened this issue Nov 12, 2023 · 1 comment · Fixed by #435
Assignees
Labels
bug Something isn't working

Comments

@cpacker
Copy link
Collaborator

cpacker commented Nov 12, 2023

Describe the bug
When you select a non-default context window with memgpt configure, then do memgpt run and create a new agent, the new agent does not use the selected context window size.

To Reproduce

memgpt configure, set context window to 4k:

% memgpt configure                         
? Do you want to enable MemGPT with OpenAI? No
? Do you want to enable MemGPT with Azure? No
? Select default inference endpoint: http://localhost:1234
? Select default embedding endpoint: local
? Select default preset: memgpt_chat
? Select your model's context window (for Mistral 7B models, this is probably 8k / 8192): 4096
? Select default persona: sam_pov
? Select default human: cs_phd
? Select storage backend for archival data: local
Saving config to /Users/loaner/.memgpt/config

memgpt run, create a new agent:

% memgpt run
? Would you like to select an existing agent? No
Creating new agent...
Created new agent agent_33.
Hit enter to begin (will request first MemGPT message)^C
Aborted.

Check the config.json of the new agent:

% cat ~/.memgpt/agents/agent_33/config.json
{
    "name": "agent_33",
    "persona": "sam_pov",
    "human": "cs_phd",
    "model": "local",
    "context_window": 8192,
    "preset": "memgpt_chat",
    "data_sources": [],
    "create_time": "2023-11-12 03:55:23 PM ",
    "data_source": null,
    "agent_config_path": "/Users/loaner/.memgpt/agents/agent_33/config.json"
}%         

context_window is also not present in the base config:

% cat ~/.memgpt/config 
[defaults]
model = local
preset = memgpt_chat
model_endpoint = http://localhost:1234
persona = sam_pov
human = cs_phd

[embedding]
model = local
dim = 384
chunk_size = 300

[archival_storage]
type = local

[client]
anon_clientid = 00000000000000...

Expected behavior

config.json should show 4096, not 8192.

@cpacker cpacker added the bug Something isn't working label Nov 12, 2023
@cpacker cpacker self-assigned this Nov 12, 2023
@cpacker
Copy link
Collaborator Author

cpacker commented Nov 12, 2023

Bug reported by @TheOnlyWiseJEDI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants