-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Rust nightly #12
Comments
I'm just curious: Why are you rewriting every |
The reason I did it was because to_string() no longer wanted to compile. Maybe it was some kind of glitch and it works again, or maybe it was just removed from Prelude and should have been imported explicitly. And yes, AFAIK, format! is the way to go. |
Thanks for that information @ArtemGr |
NB, for strings format! is temporarily slower than String::from_str, rust-lang/rust#20400 |
FYI, an updated patch landed at https://github.com/ArtemGr/rust-smtp/commit/aaf2147117da119fba87986e10ea012d9fe6c74c |
Merged, thank you. I am updating the tests. |
Cool! ) BTW, I'm not sure if the |
Rust-smtp fails to compile on the fresh Rust nightly.
I did a quick upgrade: https://github.com/ArtemGr/rust-smtp/commit/f7e205e637eb31bc295849b561153abda9e5b247
Not creating a pull request because you might want to fix things differently.
The text was updated successfully, but these errors were encountered: