Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make TorchStencil private method/class in Flow #178

Open
PhiSpel opened this issue Aug 1, 2024 · 1 comment
Open

make TorchStencil private method/class in Flow #178

PhiSpel opened this issue Aug 1, 2024 · 1 comment
Assignees
@PhiSpel
Labels
low-priority usability Issues and/requests regarding usabilities

Comments

@PhiSpel
Copy link
Contributor

PhiSpel commented Aug 1, 2024

TorchStencil is very good for performance. It is confusing to see it as a public class, though. So, it would be better to move it to _flow.py and make it private
@PhiSpel PhiSpel added the usability Issues and/requests regarding usabilities label Aug 1, 2024
@PhiSpel PhiSpel self-assigned this Aug 1, 2024
@PhiSpel
Copy link
Contributor Author

PhiSpel commented Aug 14, 2024

For now, making it private should be enough, since also KBCCollision uses the class

@PhiSpel PhiSpel mentioned this issue Aug 14, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhiSpel PhiSpel

Labels
low-priority usability Issues and/requests regarding usabilities
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PhiSpel