Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Let boundaries choose to affect collision OR streaming #212

Open
2 tasks
PhiSpel opened this issue Aug 14, 2024 · 0 comments
Open
2 tasks

[Feature]: Let boundaries choose to affect collision OR streaming #212

PhiSpel opened this issue Aug 14, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@PhiSpel
Copy link
Contributor

PhiSpel commented Aug 14, 2024

Is your proposal related to a problem?

The PeriodicPressureBC in https://github.com/lettucecfd/lettuce/blob/master/examples/porous_medium.ipynb can not really work with the current setup.
We need to reconsider the "collision-or-boundary->streaming" workflow.

Describe the solution you'd like

Use also no_streaming_mask to identify individual boundaries, rather than only a boolean tensor of shape [q,x,y,z]

Describe alternatives you've considered

  1. We could also insert boundaries at different steps in the simulation.
  2. Or, we could pass collision to Flow, such that it can be used in Boundary() call

Additional context

May be related to #182

@PhiSpel PhiSpel added the enhancement New feature or request label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants