Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance]: Improve BC Typing #250

Open
PhiSpel opened this issue Oct 14, 2024 · 2 comments
Open

[Enhance]: Improve BC Typing #250

PhiSpel opened this issue Oct 14, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@PhiSpel
Copy link
Contributor

PhiSpel commented Oct 14, 2024

Contact Details

No response

Is your proposal related to a problem?

AntiBounceBackOutlet and EquilibriumOutletP share initialization, but should not inherit from each other (is not implemented, either, EquilibriumOutletP just does double init).

Describe the solution you'd like

Create a "DirectionalBC" as ABC class with the init and inherit to the other two

@PhiSpel PhiSpel added enhancement New feature or request good first issue Good for newcomers labels Oct 14, 2024
@Bran-Mak-Morn
Copy link

Hi,
the "DirectionalBC" should in the same folder like the two classes or do you intent to have some special folder for "abstract" classes? Any other requirements?
I wanna make this.

@PhiSpel
Copy link
Contributor Author

PhiSpel commented Oct 16, 2024

Hello @Bran-Mak-Morn,

yes, DirectionalBC should also be in ext/_boundary/_directionalBC (hidden).

It should inherit from Boundary, contain the fields dims, index, neighbor, w, context, and method __init__(direction, flow) similar to AntiBounceBackOutlet (without collision).

Are you familiar with LBM? If so, while you're at it, feel free to have a look at test_equilibrium_pressure_outlet.py.

Good luck and have fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants