You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AntiBounceBackOutlet and EquilibriumOutletP share initialization, but should not inherit from each other (is not implemented, either, EquilibriumOutletP just does double init).
Describe the solution you'd like
Create a "DirectionalBC" as ABC class with the init and inherit to the other two
The text was updated successfully, but these errors were encountered:
Hi,
the "DirectionalBC" should in the same folder like the two classes or do you intent to have some special folder for "abstract" classes? Any other requirements?
I wanna make this.
yes, DirectionalBC should also be in ext/_boundary/_directionalBC (hidden).
It should inherit from Boundary, contain the fields dims, index, neighbor, w, context, and method __init__(direction, flow) similar to AntiBounceBackOutlet (without collision).
Are you familiar with LBM? If so, while you're at it, feel free to have a look at test_equilibrium_pressure_outlet.py.
Contact Details
No response
Is your proposal related to a problem?
AntiBounceBackOutlet and EquilibriumOutletP share initialization, but should not inherit from each other (is not implemented, either, EquilibriumOutletP just does double init).
Describe the solution you'd like
Create a "DirectionalBC" as ABC class with the init and inherit to the other two
The text was updated successfully, but these errors were encountered: