Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bench tweaks #546

Merged
merged 3 commits into from
Dec 15, 2018
Merged

Bench tweaks #546

merged 3 commits into from
Dec 15, 2018

Conversation

ralphtheninja
Copy link
Member

write-random-20181215-01 45 27
write-sorted-20181215-01 54 57

@ralphtheninja ralphtheninja mentioned this pull request Dec 15, 2018
Merged
vweevers
vweevers approved these changes Dec 15, 2018
View reviewed changes
Copy link
Member

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice. Some new options (e.g. writeBufferSize) aren't used because they're not passed to db.open(), and we can tweak when process.hrtime() is first called, but neither are blockers.

@vweevers vweevers added this to the 5.0.0-rc1 milestone Dec 15, 2018
@ralphtheninja
Copy link
Member Author

@vweevers Cool. Lets merge then and we can keep tweaking this as we go.

@ralphtheninja ralphtheninja merged commit 0cf69ae into master Dec 15, 2018
@ralphtheninja ralphtheninja deleted the bench-tweaks branch December 15, 2018 11:34
@rvagg rvagg mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphtheninja @vweevers