Update minimum node version required #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphtheninja
changed the title
|
We can do this by introducing |
ralphtheninja
changed the title
vweevers
approved these changes
Dec 15, 2018
wolfy1339
added a commit
to hellomouse/GNS
that referenced
this pull request
Jun 20, 2019
This change is due to Level/leveldown#552
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #551
I started with
v8.0.0and moved upwards. The problem is related tonapi_throw_error()which was added inv8.0.0but the function signature has changed from two parameters to three.https://nodejs.org/dist/latest-v10.x/docs/api/n-api.html#n_api_napi_throw_error
Update:
There are more issues, not just related to
napi_throw_error().