Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 6, use prebuildify fork for now, build on node 8 #562

Merged
merged 3 commits into from
Dec 16, 2018

Conversation

ralphtheninja
Copy link
Member

package.json Outdated Show resolved Hide resolved
@ralphtheninja
Copy link
Member Author

I'll let appveyor finish up before merging.

@ralphtheninja
Copy link
Member Author

And also needs rebasing ;)

@ralphtheninja
Copy link
Member Author

Looks like we got some error on appveyor even though the build passed

screenshot from 2018-12-16 18-31-46

@ralphtheninja
Copy link
Member Author

ralphtheninja commented Dec 16, 2018

Just checked old sodium-native setup on appveyor and it shows similar output:

screenshot from 2018-12-16 18-37-28

From https://ci.appveyor.com/project/mafintosh/sodium-native/builds/20896258/job/ql6fno6kfrwi3rs2

We don't get the yellow output though on leveldown.

@ralphtheninja ralphtheninja merged commit 0e88cde into master Dec 16, 2018
@ralphtheninja ralphtheninja deleted the prebuildify-tweaks branch December 16, 2018 17:50
@ralphtheninja
Copy link
Member Author

Merged too early, current got canceled on appveyor.

@rvagg rvagg mentioned this pull request Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants