Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Improved output when check-name is incorrect. #34

Open
JoelLefkowitz opened this issue Jul 8, 2021 · 2 comments
Open

Feature request: Improved output when check-name is incorrect. #34

JoelLefkowitz opened this issue Jul 8, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@JoelLefkowitz
Copy link
Contributor

Currently if check-name is incorrect the output is:

The requested check was never run against this ref, exiting...

Since the action already fetches all check_runs, maybe we can report the names that the user may have meant:

The requested check was never run against this ref.

Checks that ran:
- ...
- ... 

Exiting...
@matiasalbarello
Copy link
Collaborator

Hi @JoelLefkowitz. This looks like a feature that could be easily added. I'll label it as a good first issue for anyone who would like to collaborate.

@matiasalbarello matiasalbarello added enhancement New feature or request good first issue Good for newcomers labels Sep 11, 2021
@JoelLefkowitz JoelLefkowitz mentioned this issue Oct 16, 2021
Closed
@JoelLefkowitz
Copy link
Contributor Author

JoelLefkowitz commented Oct 16, 2021 •
edited
Loading

PR in #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matiasalbarello @JoelLefkowitz