Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs issue: is max file length lines or bytes/chars? #596

Closed
andrewferrier opened this issue Jul 24, 2022 · 2 comments · Fixed by #597
Closed

Docs issue: is max file length lines or bytes/chars? #596

andrewferrier opened this issue Jul 24, 2022 · 2 comments · Fixed by #597
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@andrewferrier
Copy link
Contributor

Description

In both the README and the help file, it's not clear whether max_file_length represents lines, or bytes/chars in the file.

Neovim version

N/A

Operating system and version

N/A

Expected behavior

N/A

Actual behavior

N/A

Minimal config

N/A

Steps to reproduce

N/A

Gitsigns debug messages

N/A
@andrewferrier andrewferrier added the bug Something isn't working label Jul 24, 2022
@andrewferrier
Copy link
Contributor Author

(I figured out from reading the source code it was number of lines).

@lewis6991 lewis6991 added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 25, 2022
@lewis6991
Copy link
Owner

PR welcome if you want to improve the docs.

@andrewferrier andrewferrier mentioned this issue Jul 25, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: document max_file_length fully andrewferrier/gitsigns.nvim
2 participants
@andrewferrier @lewis6991