Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish releases to luarocks #964

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

mrcjkb
Copy link
Contributor

@mrcjkb mrcjkb commented Apr 1, 2024

Hey 👋

Summary

This PR is part of a push to get neovim plugins on LuaRocks.

See also:

Things done:

  • Add a workflow that publishes tags to luarocks.org when a tag or release is pushed.

Notes:

See also this guide.

@lewis6991 lewis6991 merged commit 070875f into lewis6991:main Apr 1, 2024
5 of 6 checks passed
@mrcjkb mrcjkb deleted the luarocks branch April 2, 2024 05:57
@mrcjkb
Copy link
Contributor Author

mrcjkb commented Apr 2, 2024

@lewis6991 thanks for supporting this 😃
Would you mind running the workflow in the v0.7 tag (if you have the API key set up)? 🙏

@lewis6991
Copy link
Owner

No problem. I've ran it, but it's failed for some reason.

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Apr 3, 2024

stdout: 
stderr: Usage: .luarocks-wrapped upload [-h] [--skip-pack] [--api-key <key>]
       [--temp-key <key>] [--force] [--sign] <rockspec> [<src-rock>]

Error: option '--api-key' requires an argument

Looks like there's no API key in the repo's GitHub Actions secrets?

@lewis6991
Copy link
Owner

lewis6991 commented Apr 3, 2024

Should there be? What is the key required for?

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Apr 3, 2024

Should there be? What is the key required for?

Yes, an API key is necessary to be able to upload to luarocks.org.

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Apr 13, 2024

Should there be? What is the key required for?

Yes, an API key is necessary to be able to upload to luarocks.org.

@lewis6991 any thoughts on this?
Generally, I think it's best if plugins push to luarocks themselves, but if you would not like to open a luarocks.org account, I can also revert this and add gitsigns.nvim to the NURR, in which case it would be published under the neorocks org.

@lewis6991
Copy link
Owner

@teto did you originally set up gitsigns on Luarocks? If so do you still have the account details?

@teto
Copy link
Contributor

teto commented Apr 18, 2024

I have. Do you want me to relinquish the luarocks.org name for gitsigns ? (I would gladly do so)

@mrcjkb
Copy link
Contributor Author

mrcjkb commented May 22, 2024

I have. Do you want me to relinquish the luarocks.org name for gitsigns ? (I would gladly do so)

@teto I think the best option is for you to delete the gitsigns scm rock from the root manifest, since it's published under your personal account.

@teto
Copy link
Contributor

teto commented May 22, 2024

@lewis6991 and I convened on matrix that I would relinquish the root manifest when he is ready

@teto
Copy link
Contributor

teto commented Jul 1, 2024

I've released the name on luarocks.org since the luarocks install would fail anyway nvim-neorocks/rocks.nvim#422 . Now would be a good time to create a new release ^^

@simifalaye
Copy link

@lewis6991 Any news on when a release will be made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants