Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preview inline error in non-buffer windows #981

Closed
wants to merge 1 commit into from
Closed

fix: preview inline error in non-buffer windows #981

wants to merge 1 commit into from

Conversation

tribhuwan-kumar
Copy link

Added a condition to check whether the bcache is nil or not in get_hunks of lua/gitsigns/actions.lua.
Fix #979

lewis6991
lewis6991 reviewed Apr 5, 2024
View reviewed changes
Copy link
Owner

@lewis6991 lewis6991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function expects a non-nil bcache. Either the type needs to change or we fix where it is being passed nil.

@tribhuwan-kumar
Copy link
Author

Okay, we can fix that "where it is being passed nil"

@lewis6991 lewis6991 closed this in 1a50b94 Apr 7, 2024
@lewis6991 lewis6991 mentioned this pull request Apr 17, 2024
Closed
This was referenced Apr 17, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewis6991 lewis6991 lewis6991 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error in executing :Gitsigns preview_hunk_inline
2 participants
@tribhuwan-kumar @lewis6991