Add support for VS 2019 #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously hard-coded to only find VS 2017.
Fixes some issues building with VS 2019.
lewissbaker
commented
Sep 28, 2019
| @@ -191,6 +191,10 @@ TEST_CASE("Timer cancellation" | |||
| }())); | |||
| } | |||
|
|
|||
| // Disable this test under VS 2019.3 | |||
| // Results in ICE compiling the 'startTimer' lambda below. | |||
| #if CPPCORO_COMPILER_MSVC != 192328105 | |||
There was a problem hiding this comment.
CC: @GorNishanov I've just been trying to update cppcoro to work with MSVC 2019.3 and have started encountering some new compiler-crashes. I've disabled the problematic tests for now but wanted to give you a heads up.
The base 'Visual Studio 2019' has a later version of the compiler anyway and the current Preview version has some bugs that caused runtime crashes on optimised builds.
radzevich
reviewed
Jan 8, 2021
There was a problem hiding this comment.
Hi @lewissbaker . I switched to this branch and got build failed:
> ./cake.bat release=debug architecture=x64 lib/build.cake
Traceback (most recent call last):
File "C:\Projects\Druniks\Druniks.Prototype\lib\cppcoro\tools\cake\src\cake\runner.py", line 454, in run
configuration = engine.findConfiguration(scriptPath)
File "C:\Projects\Druniks\Druniks.Prototype\lib\cppcoro\tools\cake\src\cake\engine.py", line 335, in findConfiguration
return self.getConfiguration(configScript)
File "C:\Projects\Druniks\Druniks.Prototype\lib\cppcoro\tools\cake\src\cake\engine.py", line 308, in getConfiguration
script.execute()
File "C:\Projects\Druniks\Druniks.Prototype\lib\cppcoro\tools\cake\src\cake\script.py", line 273, in execute
exec byteCode in scriptGlobals
File "C:\Projects\Druniks\Druniks.Prototype\lib\cppcoro\config.cake", line 70, in <module>
from cake.library.compilers.msvc import getVisualStudioCompiler, findMsvcInstallDir
ImportError: cannot import name getVisualStudioCompiler
Build failed with 1 errors.
Build took 0:00:00.243.
That's because cake submodule targeting clang branch instead of master. Should the submodule branch be also updated in the scope of this PR?
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.