Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federated programs all deadlock in master #1646

Closed
edwardalee opened this issue Mar 12, 2023 · 6 comments
Closed

Federated programs all deadlock in master #1646

edwardalee opened this issue Mar 12, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@edwardalee
Copy link
Collaborator

I just pulled master, and none of the federated programs work anymore. They all deadlock. Any idea what recent change to master would cause this?

Unfortunately merged master into the branch I'm working with, tracing-federates, which means I'm dead in the water.

@edwardalee edwardalee added the bug Something isn't working label Mar 12, 2023
@edwardalee
Copy link
Collaborator Author

Maybe hold off on this. May be a configuration error on my part.

@edwardalee
Copy link
Collaborator Author

OK, looks like master is not using reactor-c/main. It is using some other branch, where the only substantive difference is that that other branch has the following line in core/CMakeLists.txt:

define(EXECUTABLE_PREAMBLE)

Tagging @petervdonovan . Why does omitting this line cause all federated programs to deadlock? Can we fix this so master works with reactor-c/main?

@petervdonovan
Copy link
Collaborator

I apologize for letting lingua-franca/master get out of sync with reactor-c/main. define(EXECUTABLE_PREAMBLE) will be in main ASAP.

@lhstrh
Copy link
Member

lhstrh commented Mar 15, 2023

Can this be closed?

@petervdonovan
Copy link
Collaborator

Yes if we merge lf-lang/reactor-c#179, which is passing its tests

@petervdonovan
Copy link
Collaborator

Okay, I just went ahead and merged reactor-c#179. It was just a couple lines of change, and it was closely tied to another PR in this repo that is already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants