Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend support to Word2Number #174

Merged
merged 13 commits into from
Mar 28, 2024
Merged

Extend support to Word2Number #174

merged 13 commits into from
Mar 28, 2024

Conversation

lfoppiano
Copy link
Owner

This PR attempts to extend the support of the word 2 number algorithm, so that we can cover also the forms such as 3.6 billion. We also include the incorrect words "billions, millions, etc.."

@coveralls
Copy link

coveralls commented Mar 26, 2024

Pull Request Test Coverage Report for Build 8463142128

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 101 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 34.462%

Files with Coverage Reduction New Missed Lines %
org/grobid/core/utilities/WordsToNumber.java 27 81.91%
org/grobid/core/engines/ValueParser.java 74 1.36%
Totals Coverage Status
Change from base Build 8447466255: 0.5%
Covered Lines: 2332
Relevant Lines: 6365

💛 - Coveralls

@lfoppiano lfoppiano marked this pull request as ready for review March 27, 2024 01:20
@lfoppiano lfoppiano linked an issue Mar 27, 2024 that may be closed by this pull request
@lfoppiano lfoppiano added the bug label Mar 27, 2024
@lfoppiano lfoppiano self-assigned this Mar 27, 2024
@lfoppiano lfoppiano linked an issue Mar 28, 2024 that may be closed by this pull request
@lfoppiano lfoppiano merged commit 4b18b6d into master Mar 28, 2024
6 checks passed
@lfoppiano lfoppiano deleted the fix-word-to-numbers branch March 28, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

word to number should support fractions "3.8 billion" incorrectly parsed
2 participants