-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MEGA65: Legacy bitmap modes always assumed at 320-pixel width #287
Comments
Thanks for the PR! I certainly will have a closer look hopefully still today. Btw, without even have too much chance to check it out right now (work time), doesn't it break other things, like linestep/display correctness in other modes than the title mentioned "legacy bitmap modes"? |
I can run more examples, but I think the hardcoded 320 width was only used in legacy modes , both hires and multicolor (check both branches). The VIC-IV "native" modes already considered the LINESTEP register. |
Ah. OK thanks for the info. I was not sure if that information was taken account by native modes, or some changes there, or not, but as I mentioned I had no time yet to really see your changes in context too much, "surely" I have time to write messages here and there all the time though even during work time, that'[s my bad habit ;) |
MEGA65: Fix #287 legacy bitmap modes always assumed at 320-pixel width
Has been merged, looks fine for me. Closing the issue now. Thanks again. |
In our current code, bitmap modes are always assumed to be 320 pixel wide, even when it is possible to switch to VIC-II legacy BMM and play with the MEGA65 VIC-IV registers to get a 360 pixel display (45*25).
I have the test program ready and I'm working on a fix, so I can take this. Thanks.
The text was updated successfully, but these errors were encountered: