Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to generate index in sr mode with 2.18 #734

Closed
wwood opened this issue Apr 21, 2021 · 3 comments
Closed

Failure to generate index in sr mode with 2.18 #734

wwood opened this issue Apr 21, 2021 · 3 comments
Labels

Comments

@wwood
Copy link

wwood commented Apr 21, 2021

Hi,

I updated to 2.18 and rerun my test code for my tool which uses minimap2 under its hood. There was a new test failure, which seems to originate from minimap2 itself. Here's code to reproduce just with minimap2 installed and a small dataset to reproduce. Indexing works by default, but fails when -x sr is specified it fails:

(/home/ben/e/coverm-dev) b2:20210421:~/git/coverm-local$ wget https://raw.githubusercontent.com/wwood/CoverM/main/tests/data/7seqs.fna
--2021-04-21 11:53:16--  https://raw.githubusercontent.com/wwood/CoverM/main/tests/data/7seqs.fna
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 185.199.109.133, 185.199.108.133, 185.199.111.133, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|185.199.109.133|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 57241 (56K) [text/plain]
Saving to: '7seqs.fna’

7seqs.fna                                            100%[=====================================================================================================================>]  55.90K  --.-KB/s    in 0.001s  

2021-04-21 11:53:16 (58.9 MB/s) - '7seqs.fna’ saved [57241/57241]

(/home/ben/e/coverm-dev) b2:20210421:~/git/coverm-local$ minimap2 -x sr -d /tmp/my.mmi 7seqs.fna 
[M::mm_idx_gen::0.002*1.41] collected minimizers
[M::mm_idx_gen::0.004*1.88] sorted minimizers
[M::main::0.005*1.65] loaded/built the index for 7 target sequence(s)
[M::mm_idx_stat] kmer size: 21; skip: 11; is_hpc: 0; #seq: 7
[M::mm_idx_stat::0.005*1.60] distinct minimizers: 9434 (100.00% are singletons); average occurrences: 1.000; average spacing: 6.044; total length: 57016
ERROR: failed to map the query file

(/home/ben/e/coverm-dev) b2:20210421:~/git/coverm-local$ minimap2 -d /tmp/my.mmi 7seqs.fna 
[M::mm_idx_gen::0.002*1.46] collected minimizers
[M::mm_idx_gen::0.003*1.91] sorted minimizers
[M::main::0.004*1.66] loaded/built the index for 7 target sequence(s)
[M::mm_idx_stat] kmer size: 15; skip: 10; is_hpc: 0; #seq: 7
[M::mm_idx_stat::0.004*1.62] distinct minimizers: 10584 (99.98% are singletons); average occurrences: 1.000; average spacing: 5.386; total length: 57016
[M::main] Version: 2.18-r1015
[M::main] CMD: minimap2 -d /tmp/my.mmi 7seqs.fna
[M::main] Real time: 0.005 sec; CPU: 0.008 sec; Peak RSS: 0.005 GB

(/home/ben/e/coverm-dev) b2:20210421:~/git/coverm-local$ minimap2 --version
2.18-r1015

Any ideas? Thanks in advance.

@alienzj
Copy link

alienzj commented May 8, 2021

@wwood Your case is indeed reproducible. I have encountered a similar problem recently.

@lh3 lh3 closed this as completed in ac146fe May 10, 2021
@lh3
Copy link
Owner

lh3 commented May 10, 2021

Thanks. That was a bug lurking around for some time.

@lh3 lh3 added the bug label May 10, 2021
@wwood
Copy link
Author

wwood commented May 11, 2021

No problem, thanks for the fix. I guess it will be out in the next release after 2.18? Until then I'll pin my downstream tool to 2.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants