Skip to content

Commit

Permalink
fix Common.isElement on node, closes #535
Browse files Browse the repository at this point in the history
  • Loading branch information
@liabru
liabru committed Jan 10, 2018
1 parent b5dc3b2 commit ec38eeb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/core/Common.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ module.exports = Common;
return obj instanceof HTMLElement;
}

return !!(obj.nodeType && obj.nodeName);
return !!(obj && obj.nodeType && obj.nodeName);
};

/**
Expand Down

2 comments on commit ec38eeb

@finscn
Copy link

@finscn finscn commented on ec38eeb Jan 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19 days ago , there was a PR for this issue: #550

Don't you like PR ?
Do you like do everything by yourself ?

@liabru
Copy link
Owner Author

@liabru liabru commented on ec38eeb Jan 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry my bad! Only just got back to working on the project, I had that fix uncommitted in my local repo for a while so I went ahead. Really need to catch up on all these PRs!

Please sign in to comment.