Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider annotating the public API with visibility annotations #1598

Open
SiegeLord opened this issue Nov 27, 2024 · 1 comment
Open

Consider annotating the public API with visibility annotations #1598

SiegeLord opened this issue Nov 27, 2024 · 1 comment

Comments

@SiegeLord
Copy link
Member

Relevant flags/attributes:

-fvisibility=hidden
__attribute__((visibility("default")))
__attribute__((visibility("protected")))
@SiegeLord
Copy link
Member Author

In particular, we ran into an issue with OpenMPT with MinGW, where a static runtime would doubly export pthread and C++ runtime symbols. A workaround at the time was:

-Wl,--exclude-libs=libpthread.a -Wl,--exclude-libs=libgcc_eh.a

SiegeLord pushed a commit that referenced this issue Nov 28, 2024
@SiegeLordEx @SiegeLord
Change how OpenMPT is linked.
6001127 
This is necessitated by OpenMPT being a C++ library.

Related: #1598
SiegeLord pushed a commit that referenced this issue Nov 28, 2024
@SiegeLordEx @SiegeLord
Change how OpenMPT is linked.
7e68d74 
This is necessitated by OpenMPT being a C++ library.

Related: #1598
(cherry picked from commit 6001127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SiegeLord