Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on the metadata in semvar version #58

Closed
yihuaf opened this issue Mar 30, 2023 · 2 comments
Closed

Clarification on the metadata in semvar version #58

yihuaf opened this issue Mar 30, 2023 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@yihuaf
Copy link

yihuaf commented Mar 30, 2023

Hi, I want to ask about the metadata in the semvar version since it produces the warning:

version requirement 1.1.1+v1.0.1 for dependency libbpf-sys includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion

If I understand this correctly, the +v1.0.1 is for information only to indicate to a human reader which libbpf version is used from upstream. Therefore, if needed, we can safely remove the metadata version from cargo manifest?

@danielocfb
Copy link
Collaborator

Thanks for bringing this up. Yes, it can likely be ignored. See https://doc.rust-lang.org/cargo/reference/resolver.html#version-metadata

@yihuaf
Copy link
Author

yihuaf commented Mar 31, 2023

Thanks for bringing this up. Yes, it can likely be ignored. See https://doc.rust-lang.org/cargo/reference/resolver.html#version-metadata

Thank you!

@yihuaf yihuaf closed this as completed Mar 31, 2023
@alexforster alexforster self-assigned this Apr 1, 2024
@alexforster alexforster added the question Further information is requested label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants