This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

Record envelope protobuf does not match spec #160

Closed

jacobheun opened this issue Jun 22, 2020 · 2 comments

Labels

kind/bug

jacobheun commented Jun 22, 2020

Signature index here is set to 5, https://github.com/libp2p/go-libp2p-core/blob/v0.6.0/record/pb/envelope.proto#L29.

The spec is 4, which is should be. https://github.com/libp2p/specs/pull/217/files#diff-1d3e44bb1e34e0581019f35b96151a0dR70

jacobheun added the kind/bug label

jacobheun mentioned this issue

feat: signed peer records data types libp2p/js-libp2p#681

Merged

2 tasks

Contributor

aschmahmann commented May 26, 2021

@jacobheun is this issue closed since the spec was changed to match?

Author

jacobheun commented May 26, 2021

Yep, closing.

jacobheun closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.