Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

Put signed peer record in the Address Change Event #136

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Put signed peer record in the Address Change Event #136

merged 3 commits into from
Mar 26, 2020

Conversation

aarshkshah1992
Copy link
Contributor

yusefnapora
yusefnapora approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@yusefnapora yusefnapora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, combining these into one event type simplifies things 👍

raulk
raulk approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nits in docs.

event/addrs.go Outdated Show resolved Hide resolved
event/addrs.go Outdated Show resolved Hide resolved
aarshkshah1992 and others added 2 commits March 27, 2020 00:04
@aarshkshah1992 @raulk
Update event/addrs.go
fd1a4d2 
Co-Authored-By: Raúl Kripalani <raul@protocol.ai>
@aarshkshah1992 @raulk
Update event/addrs.go
daf715e 
Co-Authored-By: Raúl Kripalani <raul@protocol.ai>
@aarshkshah1992 aarshkshah1992 merged commit dbfc912 into master Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@raulk raulk raulk approved these changes

@yusefnapora yusefnapora yusefnapora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarshkshah1992 @yusefnapora @raulk