Add API endpoint to disconnect peers #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
raulk
reviewed
Nov 16, 2018
connmgr.go
Outdated
| return errorResponse(err) | ||
| } | ||
|
|
||
| d.host.Network().ClosePeer(p) |
There was a problem hiding this comment.
ClosePeer returns an error. It's a synchronous call as it is, so we're going to wait until connections are closed anyway. Can we propagate the error to the caller?
connmgr.go
Outdated
| @@ -51,6 +51,15 @@ func (d *Daemon) doConnManager(req *pb.Request) *pb.Response { | |||
| d.host.ConnManager().TrimOpenConns(ctx) | |||
| return okResponse() | |||
|
|
|||
| case pb.ConnManagerRequest_DISCONNECT_PEER: | |||
There was a problem hiding this comment.
Seems a bit of a misnomer to place this operation in the namespace of ConnManager? Why not put it in the same namespace as CONNECT?
There was a problem hiding this comment.
Ok, I will move it to top-level.
|
Moved |
bigs
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22