Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly Implement Kademlia Rebalancing #354

Closed
Stebalien opened this issue Jun 18, 2019 · 5 comments
Closed

Correctly Implement Kademlia Rebalancing #354

Stebalien opened this issue Jun 18, 2019 · 5 comments
Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

When a DHT node finds a closer DHT node, it needs to forward DHT records.

@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Jun 18, 2019
@aarshkshah1992
Copy link
Contributor

@Stebalien I'd like to pick this up. Please can you give me some more background on the issue/point me to the part of the code I can dig deeper into ?

@Stebalien Stebalien added the exp/wizard Extensive knowledge (implications, ramifications) required label Jul 12, 2019
@Stebalien
Copy link
Member Author

Warning: this is a difficult issue.

  1. Read https://pdos.csail.mit.edu/~petar/papers/maymounkov-kademlia-lncs.pdf.
  2. Re-read section 2.5.

Really, I don't recommend implementing this right now as we're not sure how it will effect the network.

@Stebalien
Copy link
Member Author

The process is: Every hour, walk through all local DHT records. If we received the record within the last hour, skip it. Otherwise, call PutValue on it.

However, given the current performance of the DHT, this will likely cause more harm than good.

@dirkmc
Copy link
Contributor

dirkmc commented Jul 12, 2019

Is this a dup of #323?

@Stebalien
Copy link
Member Author

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

3 participants