Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/regression: goroutine leak #849

Closed
p-shahi opened this issue Jun 13, 2023 · 3 comments · Fixed by #851
Closed

bug/regression: goroutine leak #849

p-shahi opened this issue Jun 13, 2023 · 3 comments · Fixed by #851
Assignees
@guillaumemichel
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@p-shahi
Copy link
Member

p-shahi commented Jun 13, 2023 •
edited
Loading

@Jorropo reports:
Hey we have a goroutine leak somewhere in libp2p, is most likely a deadlock does not happear with kubo v0.20 (libp2p v0.27.3) but do with kubo v0.21-rc1 (libp2p v0.27.5), I was trying to bisect it but it sometime does not appear so it made my bisect wrong.
Tested with v0.28.0 and v0.27.6 both still have the issue.
Here is the profile and screenshot https://ipfs.io/ipfs/QmZpLiWizT6HmnbSjWrwzcp7oAdSYo9e9fsZGQh3Zdd7wM
Getting stuck here:
https://github.com/libp2p/go-libp2p/blob/b4c9fed04afd7874c7390162481b67caa783d169/p2p/protocol/identify/id.go#L406
https://github.com/libp2p/go-libp2p/blob/b4c9fed04afd7874c7390162481b67caa783d169/p2p/host/eventbus/basic.go#LL40C8-L40C8
https://github.com/libp2p/go-libp2p/blob/b4c9fed04afd7874c7390162481b67caa783d169/p2p/host/eventbus/basic.go#L397
You can start a new v0.21.0-rc1 Kubo node with accelerated DHT client (to generate a bunch of connection, you can also use the default client but will grow more slowly) and do ipfs diag profile then checkout goroutine.pprof most often has the issue.

Issue being discussed here https://filecoinproject.slack.com/archives/C03FFEVK30F/p1686692108230159
@p-shahi p-shahi added kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP labels Jun 13, 2023
@p-shahi p-shahi mentioned this issue Jun 13, 2023
Closed
@p-shahi p-shahi transferred this issue from libp2p/go-libp2p Jun 13, 2023
@p-shahi p-shahi changed the title bug/regression: goroutine leak post 0.27.3 release bug/regression: goroutine leak Jun 13, 2023
@MarcoPolo MarcoPolo mentioned this issue Jun 13, 2023
Closed
@Jorropo
Copy link
Contributor

Jorropo commented Jun 13, 2023

Code review with issue described in d373974

@Jorropo Jorropo moved this to 🥞 Todo in IPFS Shipyard Team Jun 14, 2023
@guillaumemichel
Copy link
Contributor

guillaumemichel commented Jun 14, 2023 •
edited
Loading

To be reviewed: libp2p/go-libp2p-kbucket#120

@guillaumemichel guillaumemichel mentioned this issue Jun 14, 2023
Closed
@guillaumemichel
Copy link
Contributor

addressed in #851

This was referenced Jun 15, 2023
Closed
Merged
@github-project-automation github-project-automation bot moved this from 🥞 Todo to 🎉 Done in IPFS Shipyard Team Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guillaumemichel guillaumemichel

Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: issues discovered in kubo v0.21.0-rc1 libp2p/go-libp2p-kad-dht
4 participants
@MarcoPolo @guillaumemichel @Jorropo @p-shahi