Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

Provide a nice, efficient way to close streams for reading *immediately* #28

Closed
Stebalien opened this issue Jul 18, 2018 · 1 comment
Closed

Comments

@Stebalien
Copy link
Member

Currently, one has to use AwaitEOF. However, doing this asynchronously ties up a goroutine. This sucks.

See: ipfs/kubo#5247

Stebalien added a commit to ipfs/kubo that referenced this issue Jul 18, 2018
Otherwise, we tie up the bitswap worker until the other side responds with an EOF.

fixes #5247
related to libp2p/go-libp2p-net#28

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
whyrusleeping pushed a commit to ipfs/go-bitswap that referenced this issue Jul 27, 2018
Otherwise, we tie up the bitswap worker until the other side responds with an EOF.

fixes #5247
related to libp2p/go-libp2p-net#28

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
Copy link
Member Author

libp2p/go-libp2p-core#10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant